coreboot March 2009

coreboot@coreboot.org

64 participants
316 discussions

Start a nNew thread

[patch] k8 bga fid msr check bug
by Marc Jones 20 Mar '09

20 Mar '09

Signed-off-by: Marc Jones <marcj303(a)gmail.com>

3 3

r4021 - trunk/coreboot-v2/src/northbridge/amd/amdk8
by svn＠coreboot.org 20 Mar '09

20 Mar '09

Author: mjones Date: 2009-03-20 17:03:37 +0100 (Fri, 20 Mar 2009) New Revision: 4021 Modified: trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f_dqs.c Log: Fix CPUID typo. This caused fid to memory speed calculations to be off. Signed-off-by: Marc Jones <marcj303(a)gmail.com> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c =================================================================== --- trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c 2009-03-19 12:18:13 UTC (rev 4020) +++ trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c 2009-03-20 16:03:37 UTC (rev 4021) @@ -1655,7 +1655,7 @@ /* Check for FID control support */ struct cpuid_result cpuid1; - cpuid1 = cpuid(0x8000007); + cpuid1 = cpuid(0x80000007); if( cpuid1.edx & 0x02 ) { /* Use current FID */ unsigned fid_cur; Modified: trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f_dqs.c =================================================================== --- trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f_dqs.c 2009-03-19 12:18:13 UTC (rev 4020) +++ trunk/coreboot-v2/src/northbridge/amd/amdk8/raminit_f_dqs.c 2009-03-20 16:03:37 UTC (rev 4021) @@ -426,7 +426,7 @@ /* Check for FID control support */ struct cpuid_result cpuid1; - cpuid1 = cpuid(0x8000007); + cpuid1 = cpuid(0x80000007); if( cpuid1.edx & 0x02 ) { /* Use current FID */ unsigned fid_cur;

1 0

Re: [coreboot] IRQ 9 on s2895 and s2892
by Rudolf Marek 20 Mar '09

20 Mar '09

> I tried setting it to pin2. It reboots when it jumps to the payload. hm OK. Perhaps it is really pin0. It could be found out from kernel. Just put some printk to print ioapic_i8259.pin right after label found_i8259 in io_apic.c If it is 0, then your coreboot mptable should be fixed. Rudolf

2 6

v2 resource allocator strangeness
by Carl-Daniel Hailfinger 19 Mar '09

19 Mar '09

Almost three years ago, I stumbled over an oddness in the resource allocator for bridges. Back then, multiple people on this list told me that the behaviour was expected and intended. Although I didn't understand why such behaviour would be intended, I decided not to ask for a more detailed explanation to avoid embarrassment. Fast forward to today. I'm still seeing the oddness and I no longer believe that it is intended or wanted. 00:04.0 PCI bridge [0604]: ATI Technologies Inc Device [1002:7914] (prog-if 00 [Normal decode]) Control: I/O- Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Bus: primary=00, secondary=02, subordinate=02, sec-latency=0 I/O behind bridge: 0000f000-00000fff Memory behind bridge: fff00000-000fffff Prefetchable memory behind bridge: 00000000fff00000-00000000000fffff The pattern looks like this: If there is no I/O, Mem or PrefMem behind a given bridge, the base for the given resource will be set to 0xffffffff (subject to truncation for always-zero bits), the limit will be set to 0x00000000. The upper 32 bits of memory resources are always being set to 0. Is that behaviour suggested/mandated by the PCI standard? I have access to printed copies of that standard, so I can look it up if I know where to look. It seems that many BIOS versions out there always fill in the registers with something, even if that type of resource does not exist behind the bridge. Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

r1160 - coreboot-v3/lib
by svn＠coreboot.org 19 Mar '09

19 Mar '09

Author: hailfinger Date: 2009-03-20 00:29:20 +0100 (Fri, 20 Mar 2009) New Revision: 1160 Modified: coreboot-v3/lib/vtxprintf.c Log: Fix evil typo resulting in a compile failure. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: coreboot-v3/lib/vtxprintf.c =================================================================== --- coreboot-v3/lib/vtxprintf.c 2009-03-19 13:34:53 UTC (rev 1159) +++ coreboot-v3/lib/vtxprintf.c 2009-03-19 23:29:20 UTC (rev 1160) @@ -202,7 +202,7 @@ len = strnlen(s, precision); for (i = 0; i < len; ++i) - if (!isprint(*s[i])) { + if (!isprint(s[i])) { s = "<non-ASCII characters>"; len = strlen(s); break;

1 0

855
by Peter Stuge 19 Mar '09

19 Mar '09

Hi, what is the situation with 855 again? I think someone is sort-of working on it for one system. Joseph, was it you? //Peter

4 6

DBM690T booting Windows 7
by Wang Qing Pei 19 Mar '09

19 Mar '09

Hi, all DBM690T finally can boot Windows 7 (building 7000) . Now the problem is the video seems bad, the color is not brightly. Anyway, it can boot window 7. Windows xp still does not work. I am still trying on it. Jason Wang Peking University Phone:86+13426369984 MSN:wangqingpei@hotmail.com

2 1

DBM690T booting Windows 7
by Wang Qing Pei 19 Mar '09

19 Mar '09

_____ From: Wang Qing Pei [mailto:wangqingpei@gmail.com] Sent: Thursday, March 19, 2009 11:19 PM To: 'coreboot(a)coreboot.org' Subject: DBM690T booting Windows 7 Hi, all DBM690T finally can boot Windows 7 (building 7000) . Now the problem is the video seems bad, the color is not brightly. Anyway, it can boot window 7. Windows xp still does not work. I am still trying on it. Jason Wang Peking University Phone:86+13426369984 MSN:wangqingpei@hotmail.com

1 0

Re: [coreboot] r1159 - coreboot-v3/lib
by Carl-Daniel Hailfinger 19 Mar '09

19 Mar '09

On 19.03.2009 14:34, svn(a)coreboot.org wrote: > Author: stuge > New Revision: 1159 > > v3 vtxprintf(): Stop looking for non-ASCII characters after one has been found. > > And update the string length. Many thanks to Mathias Krause for spotting this! > > Signed-off-by: Peter Stuge <peter(a)stuge.se> > Acked-by: Peter Stuge <peter(a)stuge.se> > > > Modified: coreboot-v3/lib/vtxprintf.c > =================================================================== > --- coreboot-v3/lib/vtxprintf.c 2009-03-19 12:53:57 UTC (rev 1158) > +++ coreboot-v3/lib/vtxprintf.c 2009-03-19 13:34:53 UTC (rev 1159) > @@ -202,8 +202,11 @@ > len = strnlen(s, precision); > > for (i = 0; i < len; ++i) > - if (!isprint(*s[i])) > + if (!isprint(*s[i])) { > s = "<non-ASCII characters>"; > + len = strlen(s); > Shouldn't that be len = strnlen(s, precision); to avoid overflowing any buffers? Sure, the message may be truncated due to that, but I prefer truncation to buffer overflows. > + break; > + } > if (!(flags & LEFT)) > while (len < field_width--) > tx_byte(' ', arg), count++; > Reminds me of the old saying: "Fixing one bug creates another." No offense intended. I hope that we get enough GSoC slots to find someone for the code checker project. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[PATCH] v3: Improve printk reliability
by Carl-Daniel Hailfinger 19 Mar '09

19 Mar '09

This patch tries to make printk more readable and reliable. Base 16 number printing used digits[33] instead of the more readable 'x' for the "0x" prefix. That means you have to look up an array just to find out what the code does. Change it. We already write "<NULL>" if printk gets a NULL pointer as string argument. Introduce "<almost NULL>" for string arguments with addresses below 0x400. This error happened in the past when dereferencing a struct member with a string and the struct had the address NULL. Check if all to-be-printed characters in the string are indeed printable. The idea is to catch garbage strings from stray pointers and print "<GARBAGE>" instead. This is the only part of the patch I'm not so sure about. If a string contains characters outside classic ASCII printable stuff, this will trigger. An example would be characters with diacritic marks like äöüéăçőč. Then again, I don't see localized versions of coreboot on the horizon. Maybe for payloads, but not for coreboot itself. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: corebootv3-printk_safe_strings/lib/vtxprintf.c =================================================================== --- corebootv3-printk_safe_strings/lib/vtxprintf.c (Revision 1157) +++ corebootv3-printk_safe_strings/lib/vtxprintf.c (Arbeitskopie) @@ -16,6 +16,7 @@ #define isdigit(c) ((c) >= '0' && (c) <= '9') #define is_digit isdigit #define isxdigit(c) (((c) >= '0' && (c) <= '9') || ((c) >= 'a' && (c) <= 'f') || ((c) >= 'A' && (c) <= 'F')) +#define isprint(c) ((c) == '\n' || ((c) >= ' ' && (c) <= '~')) static int skip_atoi(const char **s) { @@ -87,7 +88,7 @@ tx_byte('0', arg), count++; else if (base==16) { tx_byte('0', arg), count++; - tx_byte(digits[33], arg), count++; + tx_byte('x', arg), count++; } } if (!(type & LEFT)) @@ -194,9 +195,15 @@ s = va_arg(args, char *); if (!s) s = "<NULL>"; + /* Catch almost-NULL pointers as well */ + if ((size_t)s < 0x400) + s = "<almost NULL>"; len = strnlen(s, precision); + for (i = 0; i < len; ++i) + if (!isprint(*s[i])) + s = "<GARBAGE>"; if (!(flags & LEFT)) while (len < field_width--) tx_byte(' ', arg), count++; -- http://www.hailfinger.org/ Index: corebootv3-printk_safe_strings/lib/vtxprintf.c =================================================================== --- corebootv3-printk_safe_strings/lib/vtxprintf.c (Revision 1157) +++ corebootv3-printk_safe_strings/lib/vtxprintf.c (Arbeitskopie) @@ -16,6 +16,7 @@ #define isdigit(c) ((c) >= '0' && (c) <= '9') #define is_digit isdigit #define isxdigit(c) (((c) >= '0' && (c) <= '9') || ((c) >= 'a' && (c) <= 'f') || ((c) >= 'A' && (c) <= 'F')) +#define isprint(c) ((c) == '\n' || ((c) >= ' ' && (c) <= '~')) static int skip_atoi(const char **s) { @@ -87,7 +88,7 @@ tx_byte('0', arg), count++; else if (base==16) { tx_byte('0', arg), count++; - tx_byte(digits[33], arg), count++; + tx_byte('x', arg), count++; } } if (!(type & LEFT)) @@ -194,9 +195,15 @@ s = va_arg(args, char *); if (!s) s = "<NULL>"; + /* Catch almost-NULL pointers as well */ + if ((size_t)s < 0x400) + s = "<almost NULL>"; len = strnlen(s, precision); + for (i = 0; i < len; ++i) + if (!isprint(*s[i])) + s = "<GARBAGE>"; if (!(flags & LEFT)) while (len < field_width--) tx_byte(' ', arg), count++;

4 7

← Newer
1
...
8
9
10
11
12
13
14
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot March 2009