coreboot April 2008

coreboot@coreboot.org

75 participants
404 discussions

stage0_i586.S Try 2
by Stefan Reinauer 04 Apr '08

04 Apr '08

Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 Index: arch/x86/stage0_i586.S =================================================================== --- arch/x86/stage0_i586.S (revision 654) +++ arch/x86/stage0_i586.S (working copy) @@ -319,15 +319,8 @@ * windowoffset is the 32k-aligned window into CAR size */ .macro simplemask carsize, windowoffset - .set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000) - 4) - extractmask gas_bug_workaround, %eax - .set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000)) - extractmask gas_bug_workaround, %edx -/* Without the gas bug workaround, the entire macro would consist only of the - * two lines below. - extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax - extractmask (((\carsize - \windowoffset) / 0x1000)), %edx - */ + extractmask (((\carsize - \windowoffset) >> 12 ) - 4), %eax + extractmask (((\carsize - \windowoffset) >> 12 )), %edx .endm #if CacheSize > 0x10000

3 4

[PATCH] fix stage0_i586.S in v3
by Stefan Reinauer 04 Apr '08

04 Apr '08

The idea to this patch is from Patrick Georgi but I reimplemented it from scratch since I can't reach the other box for a few days. It fixes stage0_i586.S assembling on the latest official GNU binutils version. Without this patch the compilation fails with: AS build/arch/x86/stage0_i586.o /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S: Assembler messages: /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: expecting operand after ','; got nothing /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: missing ')' /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error: expecting operand after ','; got nothing -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 This patch fixes stage0_i586.S assembling with GNU assembler version 2.18 (i386-elf) using BFD version 2.18 Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Index: arch/x86/stage0_i586.S =================================================================== --- arch/x86/stage0_i586.S (revision 647) +++ arch/x86/stage0_i586.S (working copy) @@ -297,20 +297,20 @@ * register we want to use for CAR. * reg is the register where the IO type should be stored. */ -.macro extractmask segs, reg -.if \segs <= 0 +.macro extractmask size_segs, reg +.if \size_segs <= 0 /* The xorl here is superfluous because at the point of first execution * of this macro, %eax and %edx are cleared. Later invocations of this - * macro will have a monotonically increasing segs parameter. + * macro will have a monotonically increasing size_segs parameter. */ xorl \reg, \reg -.elseif \segs == 1 +.elseif \size_segs == 0x1000 movl $0x06000000, \reg -.elseif \segs == 2 +.elseif \size_segs == 0x2000 movl $0x06060000, \reg -.elseif \segs == 3 +.elseif \size_segs == 0x3000 movl $0x06060600, \reg -.elseif \segs >= 4 +.elseif \size_segs >= 0x4000 movl $0x06060606, \reg .endif .endm @@ -319,8 +319,8 @@ * windowoffset is the 32k-aligned window into CAR size */ .macro simplemask carsize, windowoffset - extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax - extractmask (((\carsize - \windowoffset) / 0x1000)), %edx + extractmask ((( \carsize - \windowoffset ) ) - 0x4000 ), %eax + extractmask ((( \carsize - \windowoffset ) ) ), %edx .endm #if CacheSize > 0x10000

8 33

r655 - coreboot-v3/util/xcompile
by svn＠coreboot.org 04 Apr '08

04 Apr '08

Author: stepan Date: 2008-04-05 01:38:51 +0200 (Sat, 05 Apr 2008) New Revision: 655 Modified: coreboot-v3/util/xcompile/xcompile Log: fix i386-elf binutils weirdness. Thanks to Segher Boessenkool for finding this out. (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: coreboot-v3/util/xcompile/xcompile =================================================================== --- coreboot-v3/util/xcompile/xcompile 2008-04-04 14:49:50 UTC (rev 654) +++ coreboot-v3/util/xcompile/xcompile 2008-04-04 23:38:51 UTC (rev 655) @@ -82,7 +82,7 @@ fi echo "CC_x86 := $CC" echo "AR_x86 := i386-elf-ar" - echo "AS_x86 := i386-elf-as" + echo "AS_x86 := i386-elf-as --divide" echo "LD_x86 := i386-elf-ld" echo "NM_x86 := i386-elf-nm" echo "OBJCOPY_x86 := i386-elf-objcopy"

1 0

[PATCH] Add subversion number
by Stefan Reinauer 04 Apr '08

04 Apr '08

This patch uses the svn version as the sublevel part of the coreboot version string. -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Index: Makefile =================================================================== --- Makefile (revision 647) +++ Makefile (working copy) @@ -23,7 +23,9 @@ VERSION = 3 PATCHLEVEL = 0 -SUBLEVEL = 0 +# Set the sublevel version string from the highest revision number +# of the checked out files. +SUBLEVEL := "$(shell svnversion -cn . \ | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/")"' have_dotconfig := $(wildcard .config)

5 5

[PATCH] coreinfo: Fix build for zero selected modules
by Uwe Hermann 04 Apr '08

04 Apr '08

See patch. (yes, there are valid reasons to build a coreinfo with no modules selected at all -- not all coreinfo functionality is implemented as a module; even if it would, no valid kconfig combination should result in a failing build) Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

2 2

r3216 - trunk/payloads/coreinfo
by svn＠coreboot.org 04 Apr '08

04 Apr '08

Author: uwe Date: 2008-04-04 18:49:09 +0200 (Fri, 04 Apr 2008) New Revision: 3216 Modified: trunk/payloads/coreinfo/coreinfo.c Log: Fix the case where the user selects no modules in Kconfig at all. Until now, the build would break, and even if it didn't the ELF would triple-fault in QEMU. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/payloads/coreinfo/coreinfo.c =================================================================== --- trunk/payloads/coreinfo/coreinfo.c 2008-04-04 15:02:45 UTC (rev 3215) +++ trunk/payloads/coreinfo/coreinfo.c 2008-04-04 16:49:09 UTC (rev 3216) @@ -72,7 +72,8 @@ for (i = 0; i < ARRAY_SIZE(modules); i++) ptr += sprintf(ptr, "F%d: %s ", i + 1, modules[i]->name); - mvprintw(23, 0, menu); + if (ARRAY_SIZE(modules) != 0) + mvprintw(23, 0, menu); #ifdef CONFIG_SHOW_DATE_TIME mvprintw(23, 59, "%02d/%02d/20%02d - %02d:%02d:%02d", @@ -121,6 +122,9 @@ static void redraw_module(void) { + if (ARRAY_SIZE(modules) == 0) + return; + wclear(modwin); modules[curwin]->redraw(modwin); refresh(); @@ -133,7 +137,8 @@ center(0, "coreinfo v0.1"); print_menu(); - modules[curwin]->redraw(modwin); + if (ARRAY_SIZE(modules) != 0) + modules[curwin]->redraw(modwin); refresh(); while (1) { @@ -145,14 +150,16 @@ if (key >= KEY_F(1) && key <= KEY_F(9)) { unsigned char ch = key - KEY_F(1); - if (ch < ARRAY_SIZE(modules)) { + if (ch <= ARRAY_SIZE(modules)) { + if (ch == ARRAY_SIZE(modules)) + continue; curwin = ch; redraw_module(); continue; } } - if (modules[curwin]->handle) + if (ARRAY_SIZE(modules) != 0 && modules[curwin]->handle) if (modules[curwin]->handle(key)) redraw_module(); }

1 0

r3215 - trunk/coreboot-v2/src/cpu/x86/car
by svn＠coreboot.org 04 Apr '08

04 Apr '08

Author: hailfinger Date: 2008-04-04 17:02:45 +0200 (Fri, 04 Apr 2008) New Revision: 3215 Modified: trunk/coreboot-v2/src/cpu/x86/car/cache_as_ram.inc Log: Add a workaround for a bug in some binutils version which strictly interpret whitespace as macro argument delimiter. Since the code is preprocessed by gcc and the tokenizer may insert whitespace, that can fail. http://sourceware.org/bugzilla/show_bug.cgi?id=669 The same change was committed in r3044 to the AMD CAR code. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: trunk/coreboot-v2/src/cpu/x86/car/cache_as_ram.inc =================================================================== --- trunk/coreboot-v2/src/cpu/x86/car/cache_as_ram.inc 2008-04-04 13:28:10 UTC (rev 3214) +++ trunk/coreboot-v2/src/cpu/x86/car/cache_as_ram.inc 2008-04-04 15:02:45 UTC (rev 3215) @@ -158,8 +158,15 @@ * windowoffset is the 32k-aligned window into CAR size */ .macro simplemask carsize, windowoffset + .set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000) - 4) + extractmask gas_bug_workaround, %eax + .set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000)) + extractmask gas_bug_workaround, %edx +/* Without the gas bug workaround, the entire macro would consist only of the + * two lines below. extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax extractmask (((\carsize - \windowoffset) / 0x1000)), %edx + */ .endm #if CacheSize > 0x10000

1 0

r654 - coreboot-v3/arch/x86
by svn＠coreboot.org 04 Apr '08

04 Apr '08

Author: hailfinger Date: 2008-04-04 16:49:50 +0200 (Fri, 04 Apr 2008) New Revision: 654 Modified: coreboot-v3/arch/x86/stage0_i586.S Log: Add a workaround for a bug in some binutils version which strictly interpret whitespace as macro argument delimiter. Since the code is preprocessed by gcc and the tokenizer may insert whitespace, that can fail. http://sourceware.org/bugzilla/show_bug.cgi?id=669 This was committed as r3044 in coreboot v2. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: coreboot-v3/arch/x86/stage0_i586.S =================================================================== --- coreboot-v3/arch/x86/stage0_i586.S 2008-04-04 14:02:39 UTC (rev 653) +++ coreboot-v3/arch/x86/stage0_i586.S 2008-04-04 14:49:50 UTC (rev 654) @@ -319,8 +319,15 @@ * windowoffset is the 32k-aligned window into CAR size */ .macro simplemask carsize, windowoffset + .set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000) - 4) + extractmask gas_bug_workaround, %eax + .set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000)) + extractmask gas_bug_workaround, %edx +/* Without the gas bug workaround, the entire macro would consist only of the + * two lines below. extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax extractmask (((\carsize - \windowoffset) / 0x1000)), %edx + */ .endm #if CacheSize > 0x10000

1 0

r653 - coreboot-v3
by svn＠coreboot.org 04 Apr '08

04 Apr '08

Author: uwe Date: 2008-04-04 16:02:39 +0200 (Fri, 04 Apr 2008) New Revision: 653 Modified: coreboot-v3/HACKING Log: Document origins of util/lar/elf.h (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: coreboot-v3/HACKING =================================================================== --- coreboot-v3/HACKING 2008-04-04 13:10:05 UTC (rev 652) +++ coreboot-v3/HACKING 2008-04-04 14:02:39 UTC (rev 653) @@ -59,6 +59,11 @@ * util/lar/*: GPLv2 Independant project, but written specifically for coreboot. +* util/lar/elf.h: LGPL-2.1 or later + Source: glibc, http://ftp.gnu.org/gnu/glibc/ + Original files: elf/elf.h + Current version we use: 2.7 + * include/lar.h, util/lar/lar.h, util/lar/example.c: Dual-licensed (GPLv2 + revised BSD license)

1 0

r3214 - trunk/payloads/coreinfo
by svn＠coreboot.org 04 Apr '08

04 Apr '08

Author: uwe Date: 2008-04-04 15:28:10 +0200 (Fri, 04 Apr 2008) New Revision: 3214 Modified: trunk/payloads/coreinfo/Kconfig Log: Document a rough estimate of how much space in the ELF file each of the coreinfo features / modules will consume (trivial). The measurements were done with libpayload r3213 (but compiled with -Os), and coreinfo r3211 (also compiled with -Os). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/payloads/coreinfo/Kconfig =================================================================== --- trunk/payloads/coreinfo/Kconfig 2008-04-04 13:16:33 UTC (rev 3213) +++ trunk/payloads/coreinfo/Kconfig 2008-04-04 13:28:10 UTC (rev 3214) @@ -34,6 +34,8 @@ Show the current date and time in the lower-right corner of the coreinfo menu. + This option will increase the ELF file size by ca. 256 bytes. + endmenu menu "Modules" @@ -41,18 +43,26 @@ config MODULE_COREBOOT bool "Enable the coreboot module" default y + help + This option will increase the ELF file size by ca. 2250 bytes. config MODULE_CPUINFO bool "Enable the cpuinfo module" default y + help + This option will increase the ELF file size by ca. 2650 bytes. config MODULE_PCI bool "Enable the PCI info module" default y + help + This option will increase the ELF file size by ca. 1750 bytes. config MODULE_NVRAM bool "Enable the NVRAM dump module" default y + help + This option will increase the ELF file size by ca. 150 bytes. endmenu

1 0

← Newer
1
...
33
34
35
36
37
38
39
40
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2008