[commit] r5530 - trunk

[repository service]

Author: oxygene
Date: Sat May  8 17:50:44 2010
New Revision: 5530
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5530

Log:
Slightly improve detecting Windows. Trivial

Signed-off-by: Patrick Georgi 
Acked-by: Patrick Georgi

Modified:
   trunk/Makefile

Modified: trunk/Makefile
==============================================================================
--- trunk/Makefile	Sat May  8 13:17:24 2010	(r5529)
+++ trunk/Makefile	Sat May  8 17:50:44 2010	(r5530)
@@ -368,12 +368,12 @@
 $(obj)/ldoptions: $(obj)/config.h
    awk '/^#define ([^"])* ([^"])*$$/ {gsub("\r","",$$3); print $$2 " = " $$3 ";";}' $< > $@

-_OS=$(shell uname -s |cut -c-7)
+_OS=$(shell uname -o)
 STACK=
-ifeq ($(_OS),MINGW32)
+ifeq ($(_OS),Msys)
    STACK=-Wl,--stack,16384000
 endif
-ifeq ($(_OS),CYGWIN_)
+ifeq ($(_OS),Cygwin)
    STACK=-Wl,--stack,16384000
 endif
 $(objutil)/romcc/romcc: $(top)/util/romcc/romcc.c

[Stefan Reinauer]

On 5/8/10 5:50 PM, repository service wrote:
> Modified: trunk/Makefile
>
> --- trunk/Makefile	Sat May  8 13:17:24 2010	(r5529)
> +++ trunk/Makefile	Sat May  8 17:50:44 2010	(r5530)
> @@ -368,12 +368,12 @@
>  $(obj)/ldoptions: $(obj)/config.h
>    awk '/^#define ([^"])* ([^"])*$$/ {gsub("\r","",$$3); print $$2 " = " $$3 ";";}' $< > $@
>
> -_OS=$(shell uname -s |cut -c-7)
> +_OS=$(shell uname -o)

GNUism warning

macpro:coreboot stepan$ uname -s
Darwin
macpro:coreboot stepan$ uname -o
uname: illegal option -- o
usage: uname [-amnprsv]

[Patrick Georgi]

Am 08.05.2010 18:21, schrieb Stefan Reinauer:
> > -_OS=$(shell uname -s |cut -c-7)
> > +_OS=$(shell uname -o)
>
> GNUism warning

Platform warning.
Given that this is exclusively used for checking for mingw and cygwin
(both support this), at most this requires routing the error message to
/dev/null.

And rename the variable so it's not used for any non-windows purpose.

Patrick