Op vrijdag 14 mei 2010 20:37:49 schreef u:
Hi Nils,
until a while back the GX2 code contained code to set up the CS5535 and the CS5536. The CS5536 code under src/southbridge contained a different version of that code. But gcc chose to use the code under src/southbridge. Because that choice was rather arbitrary we cleaned up the GX2 code a while back to not call the src/southbridge init code but the version in src/northbridge, so it would work with the same code path of CS5535 and CS5536. However, the CS5536 code in src/northbridge is no good and so moved all CS5535/CS5536 code out of the GX2. The CS5535 code was moved to src/southbridge/CS5535, while the CS5536 code already contains a (working) version of that code that was previously living in the GX2 component. So, what I did is move CS5535 code to the CS5535 directory and make sure there is no southbridge code in the northbridge directory because it really does not belong there.
Stefan
Hi Stefan, Thanks for the explanation.
I tested your patch on rev5543 , see log 172. Because of the crash in vsa loading i could`t determine if the patch worked. Therefor i also tested the patch on rev5542 ,see log 174. I am not sure if this is the expected result.(hda lost interrupt)
I would be happy if i could help with more tests.
Ps.: Your patch didn`t apply cleanly , on both revisions i had to delete src/northbridge/amd/gx2/chipsetinit.c and edit src/mainboard/wyse/s50/devicetree.cb by hand.
Thanks,Nils.
-
Nils