[PATCH]Include headers instead of sources in romstage, part 2/many

[Patrick Georgi]

Hi,

attached patch completes the changes from the first part, by eliminating
the direct inclusion of pc80/serial.c in all romstage.c files.
So far, they were still around in ROMCC builds.

I moved the include to console/console.h, guarded so it's only included
for ROMCC, as this file is a direct consumer of the functions in
pc80/serial.c

It's abuild tested and

Signed-off-by: Patrick Georgi

[PATCH]Include headers instead of sources in romstage, part 2/many

[Stefan Reinauer]

On 5/8/10 10:59 PM, Patrick Georgi wrote:
> Index: src/include/lib.h
>
> --- src/include/lib.h	(Revision 5532)
> +++ src/include/lib.h	(Arbeitskopie)
> @@ -49,5 +49,7 @@
>  void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx);
>  #endif
>
> +#else /* __ROMCC__ */
> +#include "pc80/serial.c"
>  #endif /* __ROMCC__ */
>  #endif /* __LIB_H__ */

It looks like only console/console.h is actually using these functions,
so I think it should rather be included in console/console.h than in lib.h?

Stefan

[PATCH]Include headers instead of sources in romstage, part 2/many

[Patrick Georgi]

Am 08.05.2010 23:40, schrieb Stefan Reinauer:
> On 5/8/10 10:59 PM, Patrick Georgi wrote:
> > Index: src/include/lib.h
> >
> > --- src/include/lib.h	(Revision 5532)
> > +++ src/include/lib.h	(Arbeitskopie)
> > @@ -49,5 +49,7 @@
> >  void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx);
> >  #endif
> >
> > +#else /* __ROMCC__ */
> > +#include "pc80/serial.c"
> >  #endif /* __ROMCC__ */
> >  #endif /* __LIB_H__ */
>
> It looks like only console/console.h is actually using these functions,
> so I think it should rather be included in console/console.h than in lib.h?

Oops, that was the older version of the patch (this won't even compile
on all boards)

See attached patch instead

Signed-off-by: Patrick Georgi

[PATCH]Include headers instead of sources in romstage, part 2/many

[Stefan Reinauer]

On 5/8/10 11:48 PM, Patrick Georgi wrote:
> Am 08.05.2010 23:40, schrieb Stefan Reinauer:
> > On 5/8/10 10:59 PM, Patrick Georgi wrote:
> > > Index: src/include/lib.h
> > >
> > > --- src/include/lib.h	(Revision 5532)
> > > +++ src/include/lib.h	(Arbeitskopie)
> > > @@ -49,5 +49,7 @@
> > >  void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx);
> > >  #endif
> > >
> > > +#else /* __ROMCC__ */
> > > +#include "pc80/serial.c"
> > >  #endif /* __ROMCC__ */
> > >  #endif /* __LIB_H__ */
> >
> > It looks like only console/console.h is actually using these functions,
> > so I think it should rather be included in console/console.h than in lib.h?
>
> Oops, that was the older version of the patch (this won't even compile
> on all boards)
>
> See attached patch instead
>
> Signed-off-by: Patrick Georgi

Acked-by: Stefan Reinauer