Re: [coreboot] r613 - in coreboot-v3: northbridge/amd/geodelx util/x86emu

[Uwe Hermann]

On Thu, Feb 21, 2008 at 06:20:14AM +0100, [e-mail] wrote:
> Author: rminnich
> Date: 2008-02-21 06:20:14 +0100 (Thu, 21 Feb 2008)
> New Revision: 613
>
> Added:
>    coreboot-v3/util/x86emu/vm86_gdt.c
> Modified:
>    coreboot-v3/northbridge/amd/geodelx/Makefile
>    coreboot-v3/northbridge/amd/geodelx/geodelx.c
>    coreboot-v3/northbridge/amd/geodelx/vsmsetup.c
>    coreboot-v3/util/x86emu/Makefile
>    coreboot-v3/util/x86emu/vm86.c
> Log:
> This discussion is too useful to lose.

Please don't do this. That's what the list archive is for. If you want
you can add a link to the respective thread, but not copy-paste the
whole thing (including signatures!).

If it's _really_ important it should be in the code as a code comment
anyway. The commit log is not the right place for this.
> Added: coreboot-v3/util/x86emu/vm86_gdt.c
>
> --- coreboot-v3/util/x86emu/vm86_gdt.c	                        (rev 0)
> +++ coreboot-v3/util/x86emu/vm86_gdt.c	2008-02-21 05:20:14 UTC (rev 613)
> @@ -0,0 +1,95 @@
> +/*
> Erik Arjan Hendriks

This line is missing a 'Copyright (C) xxxx' part? Or is it a copy-paste
error?
> Copyright (C) 2000 Scyld.
> Copyright (C) 2000 Scyld Computing Corporation
> Copyright (C) 2001 University of California.  LA-CC Number 01-67.
> Copyright (C) 2005 [e-mail]
> Copyright (C) 2007 coresystems GmbH

Uwe.

r613 - in coreboot-v3: northbridge/amd/geodelx util/x86emu

[Carl-Daniel Hailfinger]

On 21.02.2008 14:50, Uwe Hermann wrote:
> On Thu, Feb 21, 2008 at 06:20:14AM +0100, [e-mail] wrote:
> > Author: rminnich
> > Date: 2008-02-21 06:20:14 +0100 (Thu, 21 Feb 2008)
> > New Revision: 613
> >
> > Added:
> >    coreboot-v3/util/x86emu/vm86_gdt.c
> > Modified:
> >    coreboot-v3/northbridge/amd/geodelx/Makefile
> >    coreboot-v3/northbridge/amd/geodelx/geodelx.c
> >    coreboot-v3/northbridge/amd/geodelx/vsmsetup.c
> >    coreboot-v3/util/x86emu/Makefile
> >    coreboot-v3/util/x86emu/vm86.c
> > Log:
> > This discussion is too useful to lose.
>
> Please don't do this. That's what the list archive is for. If you want
> you can add a link to the respective thread, but not copy-paste the
> whole thing (including signatures!).
>
> If it's _really_ important it should be in the code as a code comment
> anyway. The commit log is not the right place for this.

The commit log is there for a thorough description of the commit 
including its reasons. The discussion fits the description nicely.
> > Added: coreboot-v3/util/x86emu/vm86_gdt.c
> >
> > --- coreboot-v3/util/x86emu/vm86_gdt.c	                        (rev 0)
> > +++ coreboot-v3/util/x86emu/vm86_gdt.c	2008-02-21 05:20:14 UTC (rev 613)
> > @@ -0,0 +1,95 @@
> > +/*
> > Erik Arjan Hendriks
>
> This line is missing a 'Copyright (C) xxxx' part? Or is it a copy-paste
> error?

It's an error-free copy of util/x86emu/vm86.c. So the question has to be 
asked about util/x86emu/vm86.c instead. That one came from v2.
> > Copyright (C) 2000 Scyld.
> > Copyright (C) 2000 Scyld Computing Corporation
> > Copyright (C) 2001 University of California.  LA-CC Number 01-67.
> > Copyright (C) 2005 [e-mail]
> > Copyright (C) 2007 coresystems GmbH

Regards,
Carl-Daniel