v3 multiboot warnings

[Myles Watson]

This patch makes casting explicit to get rid of compiler warnings.

I think it would be nice to remove the #if 0 code in archtables.c to make it
more readable too.  Objections?

Signed-off-by: Myles Watson

Thanks,
Myles

[ron minnich]

Acked-by: Ronald G. Minnich

[Myles Watson]

> Subject: Re: [coreboot] v3 multiboot warnings
>
> Acked-by: Ronald G. Minnich

Rev 949.
Thanks,
Myles

[Jordan Crouse]

On 23/10/08 06:56 -0600, Myles Watson wrote:
> This patch makes casting explicit to get rid of compiler warnings.
>
> I think it would be nice to remove the #if 0 code in archtables.c to make it
> more readable too.  Objections?

None - if the code is in RCS we can recover it if we need it.

Jordan

[Myles Watson]

> On 23/10/08 06:56 -0600, Myles Watson wrote:
> > This patch makes casting explicit to get rid of compiler warnings.
> >
> > I think it would be nice to remove the #if 0 code in archtables.c to
>
> make it
> > more readable too.  Objections?
>
> None - if the code is in RCS we can recover it if we need it.

I just noticed the

#warning enable disabled code in archtables.c

I guess I'll let someone else decide what really needs to be removed.

Thanks,
Myles

[ron minnich]

On Thu, Oct 23, 2008 at 9:51 AM, Myles Watson  wrote:
> I just noticed the
>    #warning enable disabled code in archtables.c
>
> I guess I'll let someone else decide what really needs to be removed.

just hold on for a bit.

ron

[Carl-Daniel Hailfinger]

On 23.10.2008 14:56, Myles Watson wrote:
> This patch makes casting explicit to get rid of compiler warnings.

Explicit casts are often a sign that the code is using wrong types.
> I think it would be nice to remove the #if 0 code in archtables.c to make it
> more readable too.  Objections?
>
> Signed-off-by: Myles Watson

Regards,
Carl-Daniel

[Peter Stuge]

Carl-Daniel Hailfinger wrote:
> Explicit casts are often a sign that the code is using wrong types.

C is often too limited to succinctly express the world.

//Peter