RE: [LinuxBIOS] Merge complete....

[YhLu]

define HARD_RESET_BUS

removed, Good, get amd8111 bus from config_bus_map...

YH
> -----Original Message-----
> From: Ronald G. Minnich [mailto:[e-mail]] 
> Sent: Wednesday, June 22, 2005 11:21 AM
> To: YhLu
> Cc: Li-Ta Lo; Eric W. Biederman; LinuxBIOS
> Subject: RE: [LinuxBIOS] Merge complete....
>
> On Wed, 22 Jun 2005, YhLu wrote:
> > So please merge that into main tree...
>
> NOT YET!
>
> this merge is huge. Ollie is going through it bit by bit. We 
> are not ready to merge yet.
>
> Eric, please hold on for a while, Ollie will finish up his summary.
>
> ron

[LinuxBIOS] Merge complete....

[Li-Ta Lo]

On Wed, 2005-06-22 at 11:29 -0700, YhLu wrote:
> define HARD_RESET_BUS
>
> removed, Good, get amd8111 bus from config_bus_map...

Eric,

Is there any reason you put reset.c in every mainboard directory but
the only thing in these reset.c is #include "amd8111_reset.c" ?

[LinuxBIOS] Merge complete....

[Li-Ta Lo]

On Wed, 2005-06-22 at 12:34 -0600, Li-Ta Lo wrote:
> On Wed, 2005-06-22 at 11:29 -0700, YhLu wrote:
> > define HARD_RESET_BUS
> >
> > removed, Good, get amd8111 bus from config_bus_map...
>
> Eric,
>
> Is there any reason you put reset.c in every mainboard directory but
> the only thing in these reset.c is #include "amd8111_reset.c" ?

And node_link_to_bus in amd8111_reset.c and every auto.c?

[LinuxBIOS] Merge complete....

Li-Ta Lo  writes:
> On Wed, 2005-06-22 at 11:29 -0700, YhLu wrote:
> > define HARD_RESET_BUS
> >
> > removed, Good, get amd8111 bus from config_bus_map...
>
> Eric,
>
> Is there any reason you put reset.c in every mainboard directory but
> the only thing in these reset.c is #include "amd8111_reset.c" ?

Because hard_reset() needs a per motherboard definition.
hard_reset and a small handful of other routines are effectively
motherboard methods, and if you have someone creative
building hardware you can get into some ugly situations if you
over generalize, and define them at the chipset level.  What if
you have 2 8111's?

Eric