[LinuxBIOS] [RFC] Fix up compilation of usb debug in the tree

[Carl-Daniel Hailfinger]

Hi,

this patch will fix some compilation breakage for boards with
usb debug configured. So far that's fine.

However, the src/northbridge/amd/amdk8/coherent_ht_car.c change
will break most targets. The u8/u32 typedefs shouldn't be in that
file anyway. Is there any header just for such typedefs?

The ehci.h and it8716f_early_init.c parts can be safely applied
without introducing further breakage.

Signed-off-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

Index: src/include/ehci.h
===================================================================
--- src/include/ehci.h  (Revision 2563)
+++ src/include/ehci.h  (Arbeitskopie)
@@ -1,6 +1,9 @@
 #ifndef EHCI_H
 #define EHCI_H

+/* we need u8/u16/u32 defines from somewhere */
+#include "pc80/vga.h"
+
 struct ehci_caps {
         /* these fields are specified as 8 and 16 bit registers,
          * but some hosts can't perform 8 or 16 bit PCI accesses.
Index: src/superio/ite/it8716f/it8716f_early_init.c
===================================================================
--- src/superio/ite/it8716f/it8716f_early_init.c        (Revision 0)
+++ src/superio/ite/it8716f/it8716f_early_init.c        (Revision 0)
@@ -0,0 +1,15 @@
+#include <arch/romcc_io.h>
+#include "it8716f.h"
+
+static void it8716f_disable_dev(device_t dev)
+{
+       pnp_set_logical_device(dev);
+       pnp_set_enable(dev, 0);
+}
+static void it8716f_enable_dev(device_t dev, unsigned iobase)
+{
+       pnp_set_logical_device(dev);
+       pnp_set_enable(dev, 0);
+       pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
+       pnp_set_enable(dev, 1);
+}
Index: src/northbridge/amd/amdk8/coherent_ht_car.c
===================================================================
--- src/northbridge/amd/amdk8/coherent_ht_car.c (Revision 2563)
+++ src/northbridge/amd/amdk8/coherent_ht_car.c (Arbeitskopie)
@@ -78,8 +78,10 @@

#define DEFAULT 0x00010101     /* default row entry */

+#if 0
 typedef uint8_t u8;
 typedef uint32_t u32;
+#endif

#ifndef CROSS_BAR_47_56
        #define CROSS_BAR_47_56 0

[Stefan Reinauer]

* Carl-Daniel Hailfinger  [070228 14:30]:
> Hi,
>
> this patch will fix some compilation breakage for boards with
> usb debug configured. So far that's fine.
>
> However, the src/northbridge/amd/amdk8/coherent_ht_car.c change
> will break most targets. The u8/u32 typedefs shouldn't be in that
> file anyway. Is there any header just for such typedefs?

./src/arch/i386/include/stdint.h maybe. in v3 we have types.h and don't
use stdint types anymore.

Stefan

[LinuxBIOS] [PATCH] Add missing it8716f_early_init.c

[Uwe Hermann]

On Wed, Feb 28, 2007 at 02:30:17PM +0100, Carl-Daniel Hailfinger wrote:
> Index: src/superio/ite/it8716f/it8716f_early_init.c
>
> --- src/superio/ite/it8716f/it8716f_early_init.c        (Revision 0)
> +++ src/superio/ite/it8716f/it8716f_early_init.c        (Revision 0)
> @@ -0,0 +1,15 @@
> +#include <arch/romcc_io.h>
> +#include "it8716f.h"
>
> +static void it8716f_disable_dev(device_t dev)
> +{
>   pnp_set_logical_device(dev);
>   pnp_set_enable(dev, 0);
>
> +}
> +static void it8716f_enable_dev(device_t dev, unsigned iobase)
> +{
>   pnp_set_logical_device(dev);
>   pnp_set_enable(dev, 0);
>   pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
>   pnp_set_enable(dev, 1);
>
> +}

Oops, I forgot to 'svn add' this file when I applied the patch from
http://www.openbios.org/pipermail/linuxbios/2007-February/018330.html

Here's a patch with just that part and a proper license header.

Uwe.

[LinuxBIOS] [PATCH] Add missing it8716f_early_init.c

[Carl-Daniel Hailfinger]

On 02.03.2007 03:58, Uwe Hermann wrote:
> On Wed, Feb 28, 2007 at 02:30:17PM +0100, Carl-Daniel Hailfinger wrote:
> > Index: src/superio/ite/it8716f/it8716f_early_init.c
>
> Add missing it8716f_early_init.c file, which got lost in the commit of
> http://www.openbios.org/pipermail/linuxbios/2007-February/018330.html
> in revision 2559.
>
> Signed-off-by: Uwe Hermann

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[LinuxBIOS] [PATCH] Add missing it8716f_early_init.c

[Uwe Hermann]

On Fri, Mar 02, 2007 at 01:18:37PM +0100, Carl-Daniel Hailfinger wrote:
> On 02.03.2007 03:58, Uwe Hermann wrote:
> > On Wed, Feb 28, 2007 at 02:30:17PM +0100, Carl-Daniel Hailfinger wrote:
> > > Index: src/superio/ite/it8716f/it8716f_early_init.c
> >
> > Add missing it8716f_early_init.c file, which got lost in the commit of
> > http://www.openbios.org/pipermail/linuxbios/2007-February/018330.html
> > in revision 2559.
> >
> > Signed-off-by: Uwe Hermann
>
> Acked-by: Carl-Daniel Hailfinger

Committed in r2566.

Here's the remainder of your patch...

Uwe.

[LinuxBIOS] [PATCH] Add missing it8716f_early_init.c

[Carl-Daniel Hailfinger]

On 02.03.2007 13:33, Uwe Hermann wrote:
> On Fri, Mar 02, 2007 at 01:18:37PM +0100, Carl-Daniel Hailfinger wrote:
> > On 02.03.2007 03:58, Uwe Hermann wrote:
> > > On Wed, Feb 28, 2007 at 02:30:17PM +0100, Carl-Daniel Hailfinger wrote:
>
> Here's the remainder of your patch...

Thanks!
> Fix some compilation breakage for boards with
> usb debug configured. So far that's fine.
>
> However, the src/northbridge/amd/amdk8/coherent_ht_car.c change
> will break most targets. The u8/u32 typedefs shouldn't be in that
> file anyway. Is there any header just for such typedefs?
>
> The ehci.h part can be safely applied without introducing further breakage.
>
> Signed-off-by: Carl-Daniel Hailfinger 
> Signed-off-by: Uwe Hermann

I'm currently reworkking that part of the patch to not break abuild.

Regards,
Carl-Daniel