SSDT _PPC return outside method body

[Myles Watson]

Rudolf,

In acpigen.c the code that should generate the _PPC method generates
code that when disassembled places the return outside the block.

Method (_PPC, 0, NotSerialized)
{
}
Return (0x00)

I played with it a little, but the best I could get was:

Method (_PPC, 0, NotSerialized)
{
    Return (0x00)
}
Zero

Note the extra zero after the block.  I think there's an error with
the length calculation (the argument to acpigen_patch_len() or the
return value of acpigen_write_PPC), but I'm not sure how to fix it.

Thanks,
Myles

[Rudolf Marek]

hi,

Are you using latest version? I think I fixed that.

Oh and it seems I forgot to commit the fix:

[coreboot] [PATCH] fix the _PPC method generation

Rudolf

[Rudolf Marek]

Hi all,

Its fixed,

Committed revision 3968.

I may have more time tomorrow. (to answer the more CPUs PSS states email)

Rudolf

[Myles Watson]

On Mon, Mar 2, 2009 at 3:46 PM, Rudolf Marek  wrote:
> Hi all,
>
> Its fixed,
>
> Committed revision 3968.

Thanks Rudolf.  Sorry I didn't see the fix earlier.

Myles