Re: [coreboot] [v2] r4575 - trunk/coreboot-v2/src/mainboard

[Uwe Hermann]

On Tue, Aug 25, 2009 at 04:41:38PM +0200, [e-mail] wrote:
> Add vendor strings in mainboard/Kconfig.  Trivial.
>
> Signed-off-by: Myles Watson 
> Acked-by: Myles Watson
> Modified: trunk/coreboot-v2/src/mainboard/Kconfig
>
> --- trunk/coreboot-v2/src/mainboard/Kconfig	2009-08-25 14:22:58 UTC (rev 4574)
> +++ trunk/coreboot-v2/src/mainboard/Kconfig	2009-08-25 14:41:38 UTC (rev 4575)
> @@ -97,24 +97,224 @@
>
> config MAINBOARD_VENDOR
>    string
> default "A-Trend"
> depends on VENDOR_ATREND
>
> +config MAINBOARD_VENDOR
> string
> default "Abit"
> depends on VENDOR_ABIT

Am I guessing correctly that the rationale here is that boards don't
need to do this:

+config MAINBOARD_VENDOR
+	string
+	default "MSI"
+	depends on BOARD_MSI_MS6178
+
+config MAINBOARD_PART_NUMBER
+	string
+	default "MS-6178"
+	depends on BOARD_MSI_MS6178

But instead this should be sufficient per-board?

+config MAINBOARD_PART_NUMBER
+	string
+	default "MS-6178"
+	depends on BOARD_MSI_MS6178

Thanks, Uwe.

[v2] r4575 - trunk/coreboot-v2/src/mainboard

[Myles Watson]

> Am I guessing correctly that the rationale here is that boards don't
> need to do this:
>
> +config MAINBOARD_VENDOR
> string
> default "MSI"
> depends on BOARD_MSI_MS6178
>
> +config MAINBOARD_PART_NUMBER
> string
> default "MS-6178"
> depends on BOARD_MSI_MS6178
>
> But instead this should be sufficient per-board?
>
> +config MAINBOARD_PART_NUMBER
> string
> default "MS-6178"
> depends on BOARD_MSI_MS6178

That's what I was hoping.

Thanks,
Myles