[LinuxBIOS] [PATCH] buildrom qemu patch

[Myles Watson]

This patch puts build output from qemu into log files, corrects a
reference to the compiler in the Makefile, and updates the default
compiler to be gcc34 instead of gcc32.

I'd have called it trivial except that I changed the default compiler.

Myles

Signed-off-by: Myles Watson

[LinuxBIOS] buildrom qemu patch

[Jordan Crouse]

On 13/12/07 16:54 -0700, Myles Watson wrote:
> This patch puts build output from qemu into log files, corrects a
> reference to the compiler in the Makefile, and updates the default
> compiler to be gcc34 instead of gcc32.
>
> I'd have called it trivial except that I changed the default compiler.
>
> Myles
>
> Signed-off-by: Myles Watson

Acked-by: Jordan Crouse
> Index: buildrom-devel/config/platforms/Config.in
>
> --- buildrom-devel/config/platforms/Config.in	(revision 84)
> +++ buildrom-devel/config/platforms/Config.in	(working copy)
> @@ -112,15 +112,16 @@
>    default n
>    help
>      Say 'y' here to build a patched version of QEMU to work with
>  LinuxBIOS. This downloads the correct version and patches it
>  it even builds it if you specify the QEMU_CC correctly.
>  LinuxBIOS. This downloads the correct version and patches it;
>  it even builds it if you specify the QEMU_CC correctly
>
> config QEMU_CC
>    string "Compiler to use when building QEMU"
>    depends BUILD_QEMU
> default "gcc32"
> default "gcc34"
> help
>  Set this string to point to your compiler (GCC_VER <=3.2)
>      qemu has known problems when built using gcc 4.x
>  Set this string to point to your compiler (GCC_VER 3.x)
>
> config SIMNOW
>    bool "Build for the AMD SimNow (TM) emulator"
> Index: buildrom-devel/packages/qemu/qemu.mk
> ===================================================================
> --- buildrom-devel/packages/qemu/qemu.mk	(revision 84)
> +++ buildrom-devel/packages/qemu/qemu.mk	(working copy)
> @@ -32,11 +32,11 @@
>    @ touch $@
>
> $(QEMU_STAMP_DIR)/.configured: $(QEMU_STAMP_DIR)/.patched
> @ cd $(QEMU_SRC_DIR); ./configure --cc=gcc32 --target-list=i386-softmmu
> @ cd $(QEMU_SRC_DIR); ./configure --cc=$(CONFIG_QEMU_CC) --target-list=i386-softmmu > $(QEMU_CONFIG_LOG) 2>&1
> @ touch $@
>
> $(QEMU_SRC_DIR)/i386-softmmu/qemu: $(QEMU_STAMP_DIR)/.configured
> @ make -C $(QEMU_SRC_DIR) CC=$(CONFIG_QEMU_CC) CCFLAGS="" CFLAGS="" LDFLAGS=""
> @ make -C $(QEMU_SRC_DIR) CC=$(CONFIG_QEMU_CC) CCFLAGS="" CFLAGS="" LDFLAGS="" > $(QEMU_BUILD_LOG) 2>&1
> @ echo "the qemu executable is in $(QEMU_SRC_DIR)/i386-softmmu/"
>
> $(QEMU_STAMP_DIR) $(QEMU_LOG_DIR):

[Uwe Hermann]

On Thu, Dec 13, 2007 at 04:54:44PM -0700, Myles Watson wrote:
> Index: buildrom-devel/config/platforms/Config.in
>
> --- buildrom-devel/config/platforms/Config.in	(revision 84)
> +++ buildrom-devel/config/platforms/Config.in	(working copy)
> @@ -112,15 +112,16 @@
>    default n
>    help
>      Say 'y' here to build a patched version of QEMU to work with
>  LinuxBIOS. This downloads the correct version and patches it
>  it even builds it if you specify the QEMU_CC correctly.
>  LinuxBIOS. This downloads the correct version and patches it;
>  it even builds it if you specify the QEMU_CC correctly

Why this? You remove the full stop from the sentence, which is
incorrect. Kconfig help texts should be full sentences which end
with a full stop.
> config QEMU_CC
>    string "Compiler to use when building QEMU"
>    depends BUILD_QEMU
> default "gcc32"
> default "gcc34"
> help
>  Set this string to point to your compiler (GCC_VER <=3.2)
>      qemu has known problems when built using gcc 4.x
>  Set this string to point to your compiler (GCC_VER 3.x)

Ditto, should end with full stop.

Uwe.