[PATCH] v3: Fix ADL MSM800SEV build

[Uwe Hermann]

See patch.

Someone with the board should check if '15,2' is really correct, and
whether it makes sense to enable IDE or not for this board.

Thanks, Uwe.

[Carl-Daniel Hailfinger]

On 11.07.2008 15:56, Uwe Hermann wrote:
> See patch.
>
> Someone with the board should check if '15,2' is really correct, and
> whether it makes sense to enable IDE or not for this board.
>
> Thanks, Uwe.
> Fix a build-error because of a missing 'enable_ide'.

In theory, this should not cause a build error. Then again, our DTS
concept still needs some tweaks.
> Signed-off-by: Uwe Hermann
> Index: mainboard/adl/msm800sev/dts
>
> --- mainboard/adl/msm800sev/dts	(Revision 694)
> +++ mainboard/adl/msm800sev/dts	(Arbeitskopie)
> @@ -37,6 +37,10 @@
>    	pci@1,1 {
>    		/config/("southbridge/amd/cs5536/dts");
>    	};
> pci@15,2 {
> 	/config/("southbridge/amd/cs5536/ide");
> 	enable_ide = "1";

What about removing the line above? In theory, stuff should still compile.
> };
> ioport@46 {
> 	/config/("superio/winbond/w83627hf/dts");
> 	com1enable = "1";

Regards,
Carl-Daniel

[Uwe Hermann]

On Fri, Jul 11, 2008 at 06:50:27PM +0200, Carl-Daniel Hailfinger wrote:
> > pci@15,2 {
> > 	/config/("southbridge/amd/cs5536/ide");
> > 	enable_ide = "1";
>
> What about removing the line above? In theory, stuff should still compile.

Yep, compiles, no idea if it actually works (or how) on the board.

New patch attached.

Uwe.

[ron minnich]

On Fri, Jul 11, 2008 at 12:46 PM, Uwe Hermann  wrote:
> On Fri, Jul 11, 2008 at 06:50:27PM +0200, Carl-Daniel Hailfinger wrote:
> > >       pci@15,2 {
> > >               /config/("southbridge/amd/cs5536/ide");
> > >               enable_ide = "1";
> >
> > What about removing the line above? In theory, stuff should still compile.
>
> Yep, compiles, no idea if it actually works (or how) on the board.
>
> New patch attached.

taking that out seems a mistake. Until we can test, leave too much
stuff in, don't take too much stuff out.

ron

[Carl-Daniel Hailfinger]

On 11.07.2008 21:51, ron minnich wrote:
> On Fri, Jul 11, 2008 at 12:46 PM, Uwe Hermann  wrote:
> > On Fri, Jul 11, 2008 at 06:50:27PM +0200, Carl-Daniel Hailfinger wrote:
> > > >       pci@15,2 {
> > > >               /config/("southbridge/amd/cs5536/ide");
> > > >               enable_ide = "1";
> > >
> > > What about removing the line above? In theory, stuff should still compile.
> >
> > Yep, compiles, no idea if it actually works (or how) on the board.
> >
> > New patch attached.
>
> taking that out seems a mistake. Until we can test, leave too much
> stuff in, don't take too much stuff out.

Yes, the MSM800SEV has IDE, so my line removal request was mistaken.
Your original patch is

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Uwe Hermann]

On Fri, Jul 11, 2008 at 11:15:08PM +0200, Carl-Daniel Hailfinger wrote:
> On 11.07.2008 21:51, ron minnich wrote:
> > On Fri, Jul 11, 2008 at 12:46 PM, Uwe Hermann  wrote:
> > > On Fri, Jul 11, 2008 at 06:50:27PM +0200, Carl-Daniel Hailfinger wrote:
> > > > >       pci@15,2 {
> > > > >               /config/("southbridge/amd/cs5536/ide");
> > > > >               enable_ide = "1";
> > > >
> > > > What about removing the line above? In theory, stuff should still compile.
> > >
> > > Yep, compiles, no idea if it actually works (or how) on the board.
> > >
> > > New patch attached.
> >
> > taking that out seems a mistake. Until we can test, leave too much
> > stuff in, don't take too much stuff out.
>
> Yes, the MSM800SEV has IDE, so my line removal request was mistaken.
> Your original patch is
>
> Acked-by: Carl-Daniel Hailfinger

Thanks, r695.

Uwe.