Re: [coreboot] r779 - coreboot-v3/lib

[Stefan Reinauer]

[e-mail] wrote:
> Author: hailfinger
> Date: 2008-08-17 18:56:21 +0200 (Sun, 17 Aug 2008)
> New Revision: 779
>
> Modified:
>    coreboot-v3/lib/Makefile
> Log:
> Fixed typo in r778.
>
> Signed-off-by: Carl-Daniel Hailfinger 
> Acked-by: Carl-Daniel Hailfinger
> Modified: coreboot-v3/lib/Makefile
>
> --- coreboot-v3/lib/Makefile	2008-08-17 14:21:50 UTC (rev 778)
> +++ coreboot-v3/lib/Makefile	2008-08-17 16:56:21 UTC (rev 779)
> @@ -21,10 +21,10 @@
>
> DECOMPRESSORS :=
>  ifeq ($(CONFIG_COMPRESSION_LZMA),y)
> -DECOMPRESSORS += lzma.c
> +DECOMPRESSORS += lzma.o
>  endif
>  ifeq ($(CONFIG_COMPRESSION_NRV2B),y)
> -DECOMPRESSORS += nrv2b.c
> +DECOMPRESSORS += nrv2b.o
>  endif
>
> #

I thought we're collecting the source files rather than the object files
now?

r779 - coreboot-v3/lib

[Carl-Daniel Hailfinger]

On 17.08.2008 19:05, Stefan Reinauer wrote:
> [e-mail] wrote:
> > Author: hailfinger
> > Date: 2008-08-17 18:56:21 +0200 (Sun, 17 Aug 2008)
> > New Revision: 779
> >
> > Modified:
> >    coreboot-v3/lib/Makefile
> > Log:
> > Fixed typo in r778.
> >
> > Signed-off-by: Carl-Daniel Hailfinger 
> > Acked-by: Carl-Daniel Hailfinger
> > Modified: coreboot-v3/lib/Makefile
> >
> > --- coreboot-v3/lib/Makefile	2008-08-17 14:21:50 UTC (rev 778)
> > +++ coreboot-v3/lib/Makefile	2008-08-17 16:56:21 UTC (rev 779)
> > @@ -21,10 +21,10 @@
> >
> > DECOMPRESSORS :=
> >  ifeq ($(CONFIG_COMPRESSION_LZMA),y)
> > -DECOMPRESSORS += lzma.c
> > +DECOMPRESSORS += lzma.o
> >  endif
> >  ifeq ($(CONFIG_COMPRESSION_NRV2B),y)
> > -DECOMPRESSORS += nrv2b.c
> > +DECOMPRESSORS += nrv2b.o
> >  endif
> >
> > #
>
> I thought we're collecting the source files rather than the object files
> now?

That's the subject of my other patch titled "v3: Change makefile rules
to be source-based". A mixed source/binary list in one rule doesn't
work. However, if you Ack that other patch, lib/Makefile will
effectively be reverted to r778.

Regards,
Carl-Daniel