[PATCH] Enable Direct TMDS for the RS690

[Daniel Toussaint]

Enable Direct TMDS for the RS690, which allows to display on HDMI and DVI
monitors.
Signed-off-by: Libra Li

[ron minnich]

This is a nice job. I am inclined to ack it but I don't know much
about this chipset and have no way to test any potential issues for
the 690 -- any comment from AMD?

ron

[Marc Jones]

On Fri, Aug 21, 2009 at 12:36 PM, Daniel Toussaint wrote:
> Enable Direct TMDS for the RS690, which allows to display on HDMI and DVI
> monitors.
> Signed-off-by: Libra Li

Hi,
Thanks for the patch.

Why add the code to step 6 in rs690_gfx.c when there seems to be a
spot reserved for it in  step 2?

/* step 2, TMDS, (only need if CMOS option is enabled) */
    if (cfg->gfx_tmds) {
    }

Marc

[Libra Li]

Hello,

I had reference "AMD RS690 ASIC Family Register Programming
Requirements". It's in "Chapter 6 PCIE Initialization for TMDS". That is
show "step 6".
        Thanks.

2009/8/26 Marc Jones
> On Fri, Aug 21, 2009 at 12:36 PM, Daniel Toussaint
> wrote:
> > Enable Direct TMDS for the RS690, which allows to display on HDMI and DVI
> > monitors.
> > Signed-off-by: Libra Li
>
> Hi,
> Thanks for the patch.
>
> Why add the code to step 6 in rs690_gfx.c when there seems to be a
> spot reserved for it in  step 2?
>    /* step 2, TMDS, (only need if CMOS option is enabled) */
>    if (cfg->gfx_tmds) {
>    }
>
>
> Marc

[Marc Jones]

On Tue, Aug 25, 2009 at 7:49 PM, Libra Li wrote:
> Hello,
>
> I had reference "AMD RS690 ASIC Family Register Programming
> Requirements". It's in "Chapter 6 PCIE Initialization for TMDS". That is
> show "step 6".
>         Thanks.

I see. Looks good to me. Thanks for the contribution.

I am not setup to test this but it is needed by those using TDMS.

Acked-by: Marc Jones

and checked in: r4585

Marc