AMD Mahogany Fam10 not booting

[Scott Duplichan]

I found coreboot for AMD Mahogany Fam10 is no longer working. The problem
starts with this change:
http://www.coreboot.org/pipermail/coreboot-gerrit/2013-July/002391.html

Some other older AMD boards are likely affected too. Here is a workaround:

src/device/pci_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c
index 6ddb493..22bd0b1 100644
--- a/src/device/pci_ops.c
+++ b/src/device/pci_ops.c
@@ -27,7 +27,7 @@

const struct pci_bus_operations *pci_bus_default_ops(device_t dev)
 {
-#if CONFIG_MMCONF_SUPPORT_DEFAULT
+#if CONFIG_MMCONF_SUPPORT_DEFAULT && CONFIG_NORTHBRIDGE_AMD_AMDFAM10 == 0
    return &pci_ops_mmconf;
 #else
    return &pci_cf8_conf1;

[Kyösti Mälkki]

On 02/02/2015 05:40 AM, Scott Duplichan wrote:
> I found coreboot for AMD Mahogany Fam10 is no longer working. The problem
> starts with this change:
> http://www.coreboot.org/pipermail/coreboot-gerrit/2013-July/002391.html
>
> Some other older AMD boards are likely affected too. Here is a workaround:

Hi Scott

Known issue, I am sorry you had to bisect this one too in the lack of 
bug tracking. See:

http://www.coreboot.org/pipermail/coreboot/2013-December/076813.html
http://review.coreboot.org/#/c/4541/2

It would be great if you can help us to fix RS780 properly. We want to 
use MMCONF for PCI config access to avoid any concurrency problems with 
IO 0xcf8/0xcf9 index/data pair.

Kyösti

[Carl-Daniel Hailfinger]

On 02.02.2015 06:30, Kyösti Mälkki wrote:
> On 02/02/2015 05:40 AM, Scott Duplichan wrote:
> > I found coreboot for AMD Mahogany Fam10 is no longer working. The
> > problem
> > starts with this change:
> > http://www.coreboot.org/pipermail/coreboot-gerrit/2013-July/002391.html
> >
> > Some other older AMD boards are likely affected too. [...]
>
> Known issue, I am sorry you had to bisect this one too in the lack of
> bug tracking. [...]

Would the automated testsystem have caught this? If yes, which platforms
should be present in this automated testsystem to have reasonably good
coverage of systems still relevant to the community?

I hope to get the chance to allocate resources to run a bunch of
platforms in my own automated testsystem. A list of maybe 5-10 desirable
platforms/boards would be appreciated, preferably not just Thinkpads and
Chromebooks. If this works out (should know about this by May/June),
those boards would end up testing every mainline commit.

Regards,
Carl-Daniel

[Timothy Pearson]

On 02/03/2015 06:04 PM, Carl-Daniel Hailfinger wrote:
> On 02.02.2015 06:30, Kyösti Mälkki wrote:
> > On 02/02/2015 05:40 AM, Scott Duplichan wrote:
> > > I found coreboot for AMD Mahogany Fam10 is no longer working. The
> > > problem
> > > starts with this change:
> > > http://www.coreboot.org/pipermail/coreboot-gerrit/2013-July/002391.html
> > >
> > > Some other older AMD boards are likely affected too. [...]
> >
> > Known issue, I am sorry you had to bisect this one too in the lack of
> > bug tracking. [...]
>
> Would the automated testsystem have caught this? If yes, which platforms
> should be present in this automated testsystem to have reasonably good
> coverage of systems still relevant to the community?
>
> I hope to get the chance to allocate resources to run a bunch of
> platforms in my own automated testsystem. A list of maybe 5-10 desirable
> platforms/boards would be appreciated, preferably not just Thinkpads and
> Chromebooks. If this works out (should know about this by May/June),
> those boards would end up testing every mainline commit.
>
> Regards,
> Carl-Daniel

I was looking into setting something up like this as well for the ASUS 
KFSN4-DRE series of boards (socket F K10).  If you'll be testing K10 
then maybe I don't have to do this after all.

[Scott Duplichan]

Carl-Daniel Hailfinger [mailto:[e-mail]] wrote:

]Sent: Tuesday, February 03, 2015 06:04 PM
]To: [e-mail]
]Subject: Re: [coreboot] AMD Mahogany Fam10 not booting
]
]On 02.02.2015 06:30, Kyösti Mälkki wrote:
]> On 02/02/2015 05:40 AM, Scott Duplichan wrote:
]>> I found coreboot for AMD Mahogany Fam10 is no longer working. The
]>> problem
]>> starts with this change:
]>> http://www.coreboot.org/pipermail/coreboot-gerrit/2013-July/002391.html
]>>
]>> Some other older AMD boards are likely affected too. [...]
]>
]> Known issue, I am sorry you had to bisect this one too in the lack of
]> bug tracking. [...]
]
]Would the automated testsystem have caught this? If yes, which platforms
]should be present in this automated testsystem to have reasonably good
]coverage of systems still relevant to the community?

Hello Carl-Daniel,

An automated test system would catch this problem, though setting up
such a thing sounds like a lot of work. Also, RS780 boards are a couple
of generations old now and losing importance. Why did I try to boot an
old RS780 board after all these years? The reason is that I wanted to
see if the public version of AMD simnow could boot a coreboot project.
AMD simnow is the only publically available tool I know of that lets you
step through coreboot code starting from the reset vector to see how
it works. AMD simnow might still be able to boot AMD Serengeti Cheetah,
but that one uses a really old chipset. Unfortunately the public version
of simnow supports no processor newer than family 10h. The simnow 
Mahogany family 10h model is compatible with the ECS board I have, so I
chose it. Interestingly, simnow does not catch the configuration space
problem that keeps the real board from booting. Another complication is
that the simnow RS780 model doesn't correctly handle the option to make
'BAR3' read only. This results in coreboot seeing a memory BAR that
wants 4GB of space, and that causes a boot fail.

Thanks,
Scott

]I hope to get the chance to allocate resources to run a bunch of
]platforms in my own automated testsystem. A list of maybe 5-10 desirable
]platforms/boards would be appreciated, preferably not just Thinkpads and
]Chromebooks. If this works out (should know about this by May/June),
]those boards would end up testing every mainline commit.
]
]Regards,
]Carl-Daniel

[Patrick Georgi]

Am 2015-02-04 18:01, schrieb Scott Duplichan:
> The reason is that I wanted to
> see if the public version of AMD simnow could boot a coreboot project.
> AMD simnow is the only publically available tool I know of that lets 
> you
> step through coreboot code starting from the reset vector to see how
> it works.

There's QEmu that allows single stepping, and SerialICE 
(www.serialice.com)
that is based on it allows monitoring (up to single stepping) coreboot, 
or
anything else, on real hardware (some limitations apply when timing 
critical
code is involved).

I guess Sage's probe can be used with different trade-offs for similar
purposes on supported boards.

Patrick

[Scott Duplichan]

Patrick Georgi [mailto:[e-mail]] wrote:

]Sent: Wednesday, February 04, 2015 11:57 AM
]To: Scott Duplichan
]Cc: [e-mail]
]Subject: Re: [coreboot] AMD Mahogany Fam10 not booting
]
]Am 2015-02-04 18:01, schrieb Scott Duplichan:
]> The reason is that I wanted to
]> see if the public version of AMD simnow could boot a coreboot project.
]> AMD simnow is the only publically available tool I know of that lets 
]> you step through coreboot code starting from the reset vector to see how
]> it works.
]There's QEmu that allows single stepping, and SerialICE 
](www.serialice.com)
]that is based on it allows monitoring (up to single stepping) coreboot, 
]or
]anything else, on real hardware (some limitations apply when timing 
]critical
]code is involved).

Serialice sounds useful, though only if you also have real hardware.
I think Qemu is good for developers working on certain parts of the
code. But it can't boot the same binary that boots on real hardware
like simnow can. It is unfortunate that the public version of simnow
is so limited. Simnow NDA version boot just about every AMD reference
board since Solo, the AMD 64 board from around 2000.

]I guess Sage's probe can be used with different trade-offs for similar
]purposes on supported boards.

I have used the Sage SmartProbe and it is useful. But it is a little
expensive for someone just tinkering or learning. A bigger problem
is making the jtag connection to the board. Commercial boards almost
never have the pads for soldering the jtag connector. AMD reference
boards have the needed pads, but those boards are not available to 
the general public.

]Patrick