[PATCH] Freeze SeaBIOS master tag

[Kevin O'Connor]

SeaBIOS is moving to Kconfig.  This will make it easier to configure
coreboot and seabios going forward.  However, it will also break the
coreboot build in the short term.  This patch, freezes the "master"
branch of coreboot's seabios checkout so users don't see build
failures.

Signed-off-by: Kevin O'Connor

-Kevin

--- a/payloads/external/SeaBIOS/Makefile.inc
+++ b/payloads/external/SeaBIOS/Makefile.inc
@@ -1,6 +1,6 @@

-TAG-$(CONFIG_SEABIOS_MASTER)=origin/master
+TAG-$(CONFIG_SEABIOS_MASTER)=4d0c592b138f394f96a99b6311a8ef48c24fb1c6
 TAG-$(CONFIG_SEABIOS_STABLE)=rel-0.6.1.3

all: seabios

[Peter Stuge]

Kevin O'Connor wrote:
> SeaBIOS is moving to Kconfig.  This will make it easier to configure
> coreboot and seabios going forward.  However, it will also break the
> coreboot build in the short term.  This patch, freezes the "master"
> branch of coreboot's seabios checkout so users don't see build
> failures.

Can't we just quickly fix the build after Kconfig?

//Peter

[Kevin O'Connor]

On Sat, Jan 29, 2011 at 03:38:25PM +0100, Peter Stuge wrote:
> Kevin O'Connor wrote:
> > SeaBIOS is moving to Kconfig.  This will make it easier to configure
> > coreboot and seabios going forward.  However, it will also break the
> > coreboot build in the short term.  This patch, freezes the "master"
> > branch of coreboot's seabios checkout so users don't see build
> > failures.
>
> Can't we just quickly fix the build after Kconfig?

Only if you're really, really quick.  :-)

I'm not really sure what the best way to interface to the new SeaBIOS
build is.  I suppose a .config could be copied in and "make oldconfig
run".

Freezing the master tag gives time to review an alternative system,
but I'll leave it up to others if that is necessary or not.

-Kevin

[Patrick Georgi]

Am Samstag, 29. Januar 2011, um 09:53:09 schrieb Kevin O'Connor:
> I'm not really sure what the best way to interface to the new SeaBIOS
> build is.  I suppose a .config could be copied in and "make oldconfig
> run".

The _best_ way would be to extend Kconfig to allow different prefixes per Kconfig 
file (and its children), so that seabios could have SEABIOS_* options and 
coreboot COREBOOT_*, and then just integrate the seabios kconfig into a 
coreboot submenu if seabios is around.

Of course, that's more work than most are willing to invest.
> Freezing the master tag gives time to review an alternative system,
> but I'll leave it up to others if that is necessary or not.

I vote for freeze, then.

Patrick

[Peter Stuge]

Kevin O'Connor wrote:
> > > freezes the "master" branch of coreboot's seabios checkout
> >
> > Can't we just quickly fix the build after Kconfig?
>
> Only if you're really, really quick.  :-)

We could sync seabios push and coreboot commit.
> I'm not really sure what the best way to interface to the new SeaBIOS
> build is.  I suppose a .config could be copied in and "make oldconfig
> run".

Maybe make defconfig + sed would be better? That way there will also
be a complete config if SeaBIOS adds more Kconfig options.
> Freezing the master tag gives time to review an alternative system,
> but I'll leave it up to others if that is necessary or not.

Let's fix it swiftly in parallell. IRC?

//Peter

[Patrick Georgi]

Am Samstag, 29. Januar 2011, um 16:00:41 schrieb Peter Stuge:
> > I'm not really sure what the best way to interface to the new SeaBIOS
> > build is.  I suppose a .config could be copied in and "make oldconfig
> > run".
>
> Maybe make defconfig + sed would be better? That way there will also
> be a complete config if SeaBIOS adds more Kconfig options.

oldconfig is made just for that. Send in a partial set of options, and it'll 
fill in anything missing with defaults as defined in Kconfig (and subject to the 
rough dependency mechanisms Kconfig provides)

[Stefan Reinauer]

On 29.01.2011, at 06:34, Kevin O'Connor  wrote:
> SeaBIOS is moving to Kconfig.  This will make it easier to configure
> coreboot and seabios going forward.  However, it will also break the
> coreboot build in the short term.  This patch, freezes the "master"
> branch of coreboot's seabios checkout so users don't see build
> failures.
>
> Signed-off-by: Kevin O'Connor
>
> -Kevin

Hi Kevin

Much appreciated!

However I don't think this is needed at this point.  Per default coreboot uses the stable checkout and well, the bleeding edge sometime bleeds :)

Stefan
> --- a/payloads/external/SeaBIOS/Makefile.inc
> +++ b/payloads/external/SeaBIOS/Makefile.inc
> @@ -1,6 +1,6 @@
>
> -TAG-$(CONFIG_SEABIOS_MASTER)=origin/master
> +TAG-$(CONFIG_SEABIOS_MASTER)=4d0c592b138f394f96a99b6311a8ef48c24fb1c6
> TAG-$(CONFIG_SEABIOS_STABLE)=rel-0.6.1.3
>
> all: seabios