[patch] k8 bga fid msr check bug

[Marc Jones]

Signed-off-by: Marc Jones

[Ward Vandewege]

On Thu, Mar 19, 2009 at 03:36:39PM -0600, Marc Jones wrote:
> Signed-off-by: Marc Jones

Boot tested on Supermicro H8DME.

Acked-by: Ward Vandewege

Thanks,
Ward.
> Fix CPUID typo. This caused fid to memory speed calculations to be off.
>
> Signed-off-by: Marc Jones
> Index: coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c
>
> --- coreboot-v2.orig/src/northbridge/amd/amdk8/raminit_f.c	2009-03-19 14:18:36.000000000 -0600
> +++ coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c	2009-03-19 15:30:33.000000000 -0600
> @@ -1655,7 +1655,7 @@
>
> /* Check for FID control support */
>    struct cpuid_result cpuid1;
> cpuid1 = cpuid(0x8000007);
> cpuid1 = cpuid(0x80000007);
> if( cpuid1.edx & 0x02 ) {
> /* Use current FID */
> unsigned fid_cur;
> !DSPAM:49c2bb13296901804284693!

[Carl-Daniel Hailfinger]

On 19.03.2009 22:39, Ward Vandewege wrote:
> On Thu, Mar 19, 2009 at 03:36:39PM -0600, Marc Jones wrote:
> > Signed-off-by: Marc Jones
>
> Boot tested on Supermicro H8DME.
>
> Acked-by: Ward Vandewege

A quick grep shows that src/northbridge/amd/amdk8/raminit_f_dqs.c has
exactly the same bug.

Can you fix that one as well, please?

Regards,
Carl-Daniel

[Marc Jones]

On Thu, Mar 19, 2009 at 3:53 PM, Carl-Daniel Hailfinger
 wrote:
> On 19.03.2009 22:39, Ward Vandewege wrote:
> > On Thu, Mar 19, 2009 at 03:36:39PM -0600, Marc Jones wrote:
> > > Signed-off-by: Marc Jones
> >
> > Boot tested on Supermicro H8DME.
> >
> > Acked-by: Ward Vandewege
>
> A quick grep shows that src/northbridge/amd/amdk8/raminit_f_dqs.c has
> exactly the same bug.
>
> Can you fix that one as well, please?

Fixed, Thanks for pointing that out.

r4021

Marc