Hi Ron,
congratulations for commit #900. We've come a far way since the first v3 commit.
One minor nipick, though. Unless I'm reading the patch wrong, we now discard .note.* twice.
Regards, Carl-Daniel
On 07.10.2008 01:13, svn@coreboot.org wrote:
Author: rminnich Date: 2008-10-07 01:13:38 +0200 (Tue, 07 Oct 2008) New Revision: 900
Modified: coreboot-v3/arch/x86/ldscript.ld Log: trivial: make sure that all elf notes are stripped.
Signed-off-by: Ronald G. Minnich rminnich@gmail.com Acked-by: Ronald G. Minnich rminnich@gmail.com
Modified: coreboot-v3/arch/x86/ldscript.ld
--- coreboot-v3/arch/x86/ldscript.ld 2008-10-06 23:06:32 UTC (rev 899) +++ coreboot-v3/arch/x86/ldscript.ld 2008-10-06 23:13:38 UTC (rev 900) @@ -43,6 +43,7 @@ } /DISCARD/ : { *(.comment)
*(.note) *(.note.*) }*(.note.*)
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Mon, Oct 6, 2008 at 4:17 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Hi Ron,
congratulations for commit #900. We've come a far way since the first v3 commit.
One minor nipick, though. Unless I'm reading the patch wrong, we now discard .note.* twice.
Regards, Carl-Daniel
On 07.10.2008 01:13, svn@coreboot.org wrote:
Author: rminnich Date: 2008-10-07 01:13:38 +0200 (Tue, 07 Oct 2008) New Revision: 900
Modified: coreboot-v3/arch/x86/ldscript.ld
--- coreboot-v3/arch/x86/ldscript.ld 2008-10-06 23:06:32 UTC (rev 899) +++ coreboot-v3/arch/x86/ldscript.ld 2008-10-06 23:13:38 UTC (rev 900) @@ -43,6 +43,7 @@ } /DISCARD/ : { *(.comment)
*(.note.*) *(.note) *(.note.*) }
oh boy. this is weird. I did an svn up and then checked this and did the commit. owie.
I'll look at why this might have happened.
ron
fixed r901
ron