Hallo all,
with Change 11388/commit 7dbf9c6 (edid: Use edid_mode struct to reduce redundancy) compiling coreboot for Lenovo X60 fails with this error:
CC northbridge/intel/i945/gma.ramstage.o src/northbridge/intel/i945/gma.c: In function 'intel_gma_init': src/northbridge/intel/i945/gma.c:111:19: error: 'struct edid' has no member named 'phsync' hpolarity = (edid.phsync == '-'); ^ src/northbridge/intel/i945/gma.c:112:19: error: 'struct edid' has no member named 'pvsync' vpolarity = (edid.pvsync == '-'); ^ src/northbridge/intel/i945/gma.c:115:21: error: 'struct edid' has no member named 'hborder' right_border = edid.hborder; ^ src/northbridge/intel/i945/gma.c:116:22: error: 'struct edid' has no member named 'vborder' bottom_border = edid.vborder; ^ src/northbridge/intel/i945/gma.c:117:15: error: 'struct edid' has no member named 'vbl' vblank = edid.vbl; ^ src/northbridge/intel/i945/gma.c:118:15: error: 'struct edid' has no member named 'hbl' hblank = edid.hbl; ^ src/northbridge/intel/i945/gma.c:119:14: error: 'struct edid' has no member named 'vspw' vsync = edid.vspw; ^ src/northbridge/intel/i945/gma.c:120:14: error: 'struct edid' has no member named 'hspw' hsync = edid.hspw; ^ src/northbridge/intel/i945/gma.c:121:21: error: 'struct edid' has no member named 'hso' hfront_porch = edid.hso; ^ src/northbridge/intel/i945/gma.c:122:21: error: 'struct edid' has no member named 'vso' vfront_porch = edid.vso; ^ src/northbridge/intel/i945/gma.c:163:58: error: 'struct edid' has no member named 'pixel_clock' target_frequency = conf->gpu_lvds_is_dual_channel ? edid.pixel_clock ^ src/northbridge/intel/i945/gma.c:164:14: error: 'struct edid' has no member named 'pixel_clock' : (2 * edid.pixel_clock); ^ Makefile:236: recipe for target 'build/northbridge/intel/i945/gma.ramstage.o' failed make: *** [build/northbridge/intel/i945/gma.ramstage.o] Error 1
could you please point me to how to fix this? thank you! Mono
2015-09-07 18:47 GMT+02:00 Mono lists+coreboot@donderklumpen.de:
with Change 11388/commit 7dbf9c6 (edid: Use edid_mode struct to reduce redundancy) compiling coreboot for Lenovo X60 fails with this error:
could you please point me to how to fix this?
See what changed in other files in that commit: some edid.name were replaced with edid.mode.name. You'll have to do the same in i945/gma.c
Regards, Patrick