VIA VX800 patch

[bari]

Here's the VIA vx800 patch from OLPC.

It's untested, but a good starting point for everyone.

Signed-off-by: Bari Ari

-Bari

[ron minnich]

On Tue, May 26, 2009 at 5:20 PM, bari  wrote:
> Here's the VIA vx800 patch from OLPC.
>
> It's untested, but a good starting point for everyone.
>
> Signed-off-by: Bari Ari

It's a wonderful start.

Acked-by: Ronald G. Minnich

[Carl-Daniel Hailfinger]

On 27.05.2009 02:20, bari wrote:
> Here's the VIA vx800 patch from OLPC.
>
> It's untested, but a good starting point for everyone.
>
> Signed-off-by: Bari Ari

Thanks to everyone who made this release possible!

Now we just have to get it into a mergeable shape... preferably by using
CAR and eliminating lots of ROMCC code.

I strongly recommend to take a look at Coccinelle (
http://www.emn.fr/x-info/coccinelle/ ) for any code cleanups and
conversions. It can do real magic and shrink codebases a lot while
improving readability.

Regards,
Carl-Daniel

[ron minnich]

On Tue, May 26, 2009 at 5:35 PM, Carl-Daniel Hailfinger
 wrote:
> Now we just have to get it into a mergeable shape... preferably by using
> CAR and eliminating lots of ROMCC code.

I am reading coccinelle now. I am guessing this works to some extent.
I'd like to merge it as-is and then it up clean over time so we have a
baseline, which is the OLPC code, which we can back out to if we hit a
problem.

thanks

ron

[Carl-Daniel Hailfinger]

On 27.05.2009 02:44, ron minnich wrote:
> I'd like to merge it as-is and then it up clean over time so we have a
> baseline, which is the OLPC code, which we can back out to if we hit a
> problem.

Given the sorry state of chipset vendor participation in coreboot right
now, I think merging is the way forward even if the code is not really
what we would merge immediately under better circumstances.

Regards,
Carl-Daniel

[bari]

Carl-Daniel Hailfinger wrote:
> On 27.05.2009 02:44, ron minnich wrote:
> > I'd like to merge it as-is and then it up clean over time so we have a
> > baseline, which is the OLPC code, which we can back out to if we hit a
> > problem.
>
> Given the sorry state of chipset vendor participation in coreboot right
> now, I think merging is the way forward even if the code is not really
> what we would merge immediately under better circumstances.

The rumor is that this code should be very portable to some newer 
chipsets in the same family. This means that this could support about 
100 new netbooks that will be released in the next year. Of course this 
all depends on which EC is used in the designs.

-Bari

[Peter Stuge]

bari wrote:
> > I think merging is the way forward

I completely agree with that, Carl-Daniel!
> This means that this could support about 100 new netbooks that will
> be released in the next year. Of course this all depends on which EC
> is used in the designs.

I hope to learn a bit more about the EC situation later on.

//Peter

[Uwe Hermann]

On Tue, May 26, 2009 at 07:20:12PM -0500, bari wrote:
> Here's the VIA vx800 patch from OLPC.
>
> It's untested, but a good starting point for everyone.
>
> Signed-off-by: Bari Ari

Thanks, committed in r4313.

I agree we should get this merged first, then work from svn to improve
the code.

See below for a number of mostly small changes I did before the commit:
> Index: src/northbridge/via/vx800/ddr2init/DramUtil.c
>
> --- src/northbridge/via/vx800/ddr2init/DramUtil.c	(revision 0)
> +++ src/northbridge/via/vx800/ddr2init/DramUtil.c	(revision 0)
> @@ -0,0 +1,247 @@
> +/*
> This file is part of the coreboot project.
> Copyright (C) 2009 One Laptop per Child, Association, Inc.

Missing line:
 * This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; version 2 of the License.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> */
> Index: src/northbridge/via/vx800/ddr2init/vx800/DevInit.c
>
> --- src/northbridge/via/vx800/ddr2init/vx800/DevInit.c	(revision 0)
> +++ src/northbridge/via/vx800/ddr2init/vx800/DevInit.c	(revision 0)
> @@ -0,0 +1,1318 @@
> +/*
> This file is part of the coreboot project.
> Copyright (C) 2009 One Laptop per Child, Association, Inc.
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; version 2 of the License

Missing full stop.
> Index: src/northbridge/via/vx800/romstrap.inc
>
> --- src/northbridge/via/vx800/romstrap.inc	(revision 0)
> +++ src/northbridge/via/vx800/romstrap.inc	(revision 0)
> @@ -0,0 +1,52 @@
> +/*
> This file is part of the coreboot project.
> Copyright (C) 2004 Tyan Computer
> (Written by Yinghai Lu  for Tyan Computer)
> Copyright (C) 2007 Rudolf Marek
> Copyright (C) 2009 One Laptop per Child, Association, Inc.

One useless newline.
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; version 2 of the License.
> Index: src/northbridge/via/vx800/DrivingClkPhaseData.h
>
> --- src/northbridge/via/vx800/DrivingClkPhaseData.h	(revision 0)
> +++ src/northbridge/via/vx800/DrivingClkPhaseData.h	(revision 0)
> @@ -0,0 +1,69 @@
> +/*
> This file is part of the coreboot project.
> Copyright (C) 2009 One Laptop per Child, Association, Inc.
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; version 2 of the License

Missing full stop.
> Index: src/northbridge/via/vx800/vx800_early_serial.c
>
> --- src/northbridge/via/vx800/vx800_early_serial.c	(revision 0)
> +++ src/northbridge/via/vx800/vx800_early_serial.c	(revision 0)

Missing GPL header in this file. I took the freedom to add the usual
"(C) 2009 OLPC, GPL2" header, please complain if the license should
be different for this file.
> Index: src/northbridge/via/vx800/Config.lb
>
> --- src/northbridge/via/vx800/Config.lb	(revision 0)
> +++ src/northbridge/via/vx800/Config.lb	(revision 0)
> @@ -0,0 +1,25 @@
> +##
> +## This file is part of the coreboot project.
> +##
> +## Copyright (C) 2009 One Laptop per Child, Association, Inc.
> +##
> +## This program is free software; you can redistribute it and/or modify
> +## it under the terms of the GNU General Public License as published by
> +## the Free Software Foundation; version 2 of the License

Missing full stop.

My suggestion is to semi-automatically convert all the code to our
coding guidelines using indent plus manual fixups (do _not_ blindly
run indent and commit, this will surely not work properly; the indent
output will definately need some fixing).
I think I can do an indent-run today or so, but other people should then
hold off of additional changes before the indenting has been committed,
otherwise patches will need lost of ugly rebasing.

Thanks, Uwe.

[Richard Smith]

Uwe Hermann wrote:
> On Tue, May 26, 2009 at 07:20:12PM -0500, bari wrote:
> > Here's the VIA vx800 patch from OLPC.
> >
> > It's untested, but a good starting point for everyone.
> >
> > Signed-off-by: Bari Ari
>
> Thanks, committed in r4313.
>
> I agree we should get this merged first, then work from svn to improve
> the code.

Awesome.  Glad the code is finally out.  Enjoy.