Hi Stefan, It sounds indeed better to move the GDT above 1MB. But i think that it is not fair to say i moved it down, because it never was above 1MB on GX2 (non-car) boards, see options.lb .
It did`t give any build errors on kconfig because real_mode_switch_call_vsm was commented out and some other things were removed therefor vsm loading is broken on GX2 for at least 5 months. I think the automated Kbuild system is a nice method to check patches but when a board gets broken to shut of build errors I think there is something wrong. I think all the new improvements in coreboot are really nice but the downside is that (reading the list for quite some time) probably 90 percent of the boards do not work anymore and almost nobody tests them. My priority would be to get as much boards as possible working again and then improve them if possible.
As these are my first programming steps (mostly copy and paste) i won`t be able to follow your suggestions. I hope someone else knows how and has the time to do it.
Thank,Nils.
P.s. My patch for MSRTOOL from some time ago has had not much interest also.
Nils wrote:
My priority would be to get as much boards as possible working again and then improve them if possible.
I completely agree with this. It's just a lot of work, for the few developers that are active.
P.s. My patch for MSRTOOL from some time ago has had not much interest also.
I certainly appreciate your contribution!
I want to review it against the data sheet but have had no time so far. If anyone else is up for doing a review please do so. It's simple but especially important for the decoding tools, since there is no other reference than the documentation. On the other hand, all that can be checked for is typos and copypaste errors - so it is very easy to help with this task. Remember - everyone is encouraged to send Acked-by! :)
Thanks
//Peter
-
Nils -
Peter Stuge