Author: jcrouse Date: 2008-01-11 19:23:47 +0100 (Fri, 11 Jan 2008) New Revision: 3046
Modified: trunk/LinuxBIOSv2/targets/buildtarget Log: Add the ability to extend CFLAGS as needed for several new distros Signed-off-by: Ronald G. Minnich rminnich@gmail.com Acked-by: Peter Stuge peter@stuge.se Acked-by: Stefan Reinauer stepan@coresystems.de Acked-by: Jordan Crouse jordan.crouse@amd.com
Modified: trunk/LinuxBIOSv2/targets/buildtarget
--- trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 00:32:07 UTC (rev 3045) +++ trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 18:23:47 UTC (rev 3046) @@ -53,4 +53,25 @@ export PYTHONPATH=$config_dir $PYTHON $config_py $config_lb $lbpath
+# now start checking for distro-specific breakage. +## This check is for the no stack protector mess. +EXTRA_CFLAGS=
+if [ -z "$CC" ]; then
CC=gcc+fi
+$CC -fno-stack-protector -S -xc /dev/null -o .$$.tmp
+if [ $? -eq 0 ]; then
EXTRA_CFLAGS=-fno-stack-protector+fi
This adds the flag for me, even though I didn't need it. Was that intended?
Myles
+rm -rf .$$.tmp
+for i in $build_dir/Makefile.settings $build_dir/*/Makefile.settings +do
- echo CFLAGS+=$EXTRA_CFLAGS >>$i
+done
exit $?
-- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
Myles Watson wrote:
Author: jcrouse Date: 2008-01-11 19:23:47 +0100 (Fri, 11 Jan 2008) New Revision: 3046
Modified: trunk/LinuxBIOSv2/targets/buildtarget Log: Add the ability to extend CFLAGS as needed for several new distros Signed-off-by: Ronald G. Minnich rminnich@gmail.com Acked-by: Peter Stuge peter@stuge.se Acked-by: Stefan Reinauer stepan@coresystems.de Acked-by: Jordan Crouse jordan.crouse@amd.com
Modified: trunk/LinuxBIOSv2/targets/buildtarget
--- trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 00:32:07 UTC (rev 3045) +++ trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 18:23:47 UTC (rev 3046) @@ -53,4 +53,25 @@ export PYTHONPATH=$config_dir $PYTHON $config_py $config_lb $lbpath
+# now start checking for distro-specific breakage. +## This check is for the no stack protector mess. +EXTRA_CFLAGS=
+if [ -z "$CC" ]; then
CC=gcc+fi
+$CC -fno-stack-protector -S -xc /dev/null -o .$$.tmp
+if [ $? -eq 0 ]; then
EXTRA_CFLAGS=-fno-stack-protector+fi
This adds the flag for me, even though I didn't need it. Was that intended?
Myles
I don't think it matters, if your gcc wasn't compiled to do stack checking it'll just ignore it. But I think it breaks gcc 3.x, do we care? IMHO, no.
-Corey
-----Original Message----- From: Corey Osgood [mailto:corey.osgood@gmail.com] Sent: Friday, January 11, 2008 12:27 PM To: myles@mouselemur.cs.byu.edu Cc: 'Jordan Crouse'; linuxbios@linuxbios.org Subject: Re: [LinuxBIOS] r3046 - trunk/LinuxBIOSv2/targets
Myles Watson wrote:
Author: jcrouse Date: 2008-01-11 19:23:47 +0100 (Fri, 11 Jan 2008) New Revision: 3046
Modified: trunk/LinuxBIOSv2/targets/buildtarget Log: Add the ability to extend CFLAGS as needed for several new distros Signed-off-by: Ronald G. Minnich rminnich@gmail.com Acked-by: Peter Stuge peter@stuge.se Acked-by: Stefan Reinauer stepan@coresystems.de Acked-by: Jordan Crouse jordan.crouse@amd.com
Modified: trunk/LinuxBIOSv2/targets/buildtarget
--- trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 00:32:07 UTC
(rev
+++ trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 18:23:47 UTC
(rev
@@ -53,4 +53,25 @@ export PYTHONPATH=$config_dir $PYTHON $config_py $config_lb $lbpath
+# now start checking for distro-specific breakage. +## This check is for the no stack protector mess. +EXTRA_CFLAGS=
+if [ -z "$CC" ]; then
CC=gcc+fi
+$CC -fno-stack-protector -S -xc /dev/null -o .$$.tmp
+if [ $? -eq 0 ]; then
EXTRA_CFLAGS=-fno-stack-protector+fi
This adds the flag for me, even though I didn't need it. Was that
intended?
Myles
I don't think it matters, if your gcc wasn't compiled to do stack checking it'll just ignore it. But I think it breaks gcc 3.x, do we care? IMHO, no.
In that case we shouldn't do a check, we should just add it to the flags.
Myles
-Corey
On 11.01.2008 20:41, Myles Watson wrote:
-----Original Message----- From: Corey Osgood [mailto:corey.osgood@gmail.com] Sent: Friday, January 11, 2008 12:27 PM To: myles@mouselemur.cs.byu.edu Cc: 'Jordan Crouse'; linuxbios@linuxbios.org Subject: Re: [LinuxBIOS] r3046 - trunk/LinuxBIOSv2/targets
Myles Watson wrote:
Author: jcrouse Date: 2008-01-11 19:23:47 +0100 (Fri, 11 Jan 2008) New Revision: 3046
Modified: trunk/LinuxBIOSv2/targets/buildtarget Log: Add the ability to extend CFLAGS as needed for several new distros Signed-off-by: Ronald G. Minnich rminnich@gmail.com Acked-by: Peter Stuge peter@stuge.se Acked-by: Stefan Reinauer stepan@coresystems.de Acked-by: Jordan Crouse jordan.crouse@amd.com
Modified: trunk/LinuxBIOSv2/targets/buildtarget
--- trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 00:32:07 UTC
(rev
+++ trunk/LinuxBIOSv2/targets/buildtarget 2008-01-11 18:23:47 UTC
(rev
@@ -53,4 +53,25 @@ export PYTHONPATH=$config_dir $PYTHON $config_py $config_lb $lbpath
+# now start checking for distro-specific breakage. +## This check is for the no stack protector mess. +EXTRA_CFLAGS=
+if [ -z "$CC" ]; then
CC=gcc+fi
+$CC -fno-stack-protector -S -xc /dev/null -o .$$.tmp
+if [ $? -eq 0 ]; then
EXTRA_CFLAGS=-fno-stack-protector+fi
This adds the flag for me, even though I didn't need it. Was that
intended?
Myles
I don't think it matters, if your gcc wasn't compiled to do stack checking it'll just ignore it. But I think it breaks gcc 3.x, do we care? IMHO, no.
In that case we shouldn't do a check, we should just add it to the flags.
I'd say we try to stay compatible with 3.x.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
Corey Osgood -
Myles Watson