Hi,
this is another fixup round for Yinghai Lu's great patch.
It does the ROM_STREAM -> PAYLOAD rename that afaik was done after Yinghai sent his work to legal, so it is required to get that code building.
Aside from that, at least the USB2 debug console stuff is missing. Can anyone make a seperate patch for that one?
Stefan
On Tue, Feb 27, 2007 at 01:17:48PM +0100, Stefan Reinauer wrote:
this is another fixup round for Yinghai Lu's great patch.
It does the ROM_STREAM -> PAYLOAD rename that afaik was done after Yinghai sent his work to legal, so it is required to get that code building.
Acked-by: Peter Stuge peter@stuge.se
//Peter
On Tue, Feb 27, 2007 at 01:33:28PM +0100, Peter Stuge wrote:
On Tue, Feb 27, 2007 at 01:17:48PM +0100, Stefan Reinauer wrote:
this is another fixup round for Yinghai Lu's great patch.
It does the ROM_STREAM -> PAYLOAD rename that afaik was done after Yinghai sent his work to legal, so it is required to get that code building.
Acked-by: Peter Stuge peter@stuge.se
NAK by me. Please do not commit. We should fix the one remaining patch (remove PAYLOAD stuff from it, then repost to the list).
Otherwise we'll lose track of what's still missing...
Uwe.
On Tue, Feb 27, 2007 at 02:03:42PM +0100, Uwe Hermann wrote:
On Tue, Feb 27, 2007 at 01:33:28PM +0100, Peter Stuge wrote:
On Tue, Feb 27, 2007 at 01:17:48PM +0100, Stefan Reinauer wrote:
this is another fixup round for Yinghai Lu's great patch.
It does the ROM_STREAM -> PAYLOAD rename that afaik was done after Yinghai sent his work to legal, so it is required to get that code building.
Acked-by: Peter Stuge peter@stuge.se
NAK by me. Please do not commit. We should fix the one remaining patch (remove PAYLOAD stuff from it, then repost to the list).
Otherwise we'll lose track of what's still missing...
Oops, sorry, I misread the patch. This is not parts of the remaining patch, but rather fixes stuff which is in svn already.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Uwe.
* Uwe Hermann uwe@hermann-uwe.de [070227 14:52]:
NAK by me. Please do not commit. We should fix the one remaining patch (remove PAYLOAD stuff from it, then repost to the list).
Otherwise we'll lose track of what's still missing...
Oops, sorry, I misread the patch. This is not parts of the remaining patch, but rather fixes stuff which is in svn already.
Yeah, its only adapting.
Building (actually config already) fails due to the missing usb2 console now.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
cool, thanks. submitted in r2561