[PATCH]More helpful error if cbfs header magic is 0xffffffff

[Patrick Georgi]

Hi,

attached patch hopefully helps track down issues related to late 
enable_rom calls.
If the CBFS header magic is 0xffffffff, chances are that this is because 
the lower parts of the ROM aren't mapped yet. Point to 
http://www.coreboot.org/Infrastructure_Projects#CBFS, which provides 
some description and a nice table (Thanks Uwe!) about the current status.

Signed-off-by: Patrick Georgi

[PATCH]More helpful error if cbfs header magic is 0xffffffff

[Carl-Daniel Hailfinger]

On 11.11.2009 13:55, Patrick Georgi wrote:
> attached patch hopefully helps track down issues related to late
> enable_rom calls.
> If the CBFS header magic is 0xffffffff, chances are that this is
> because the lower parts of the ROM aren't mapped yet. Point to
> http://www.coreboot.org/Infrastructure_Projects#CBFS, which provides
> some description and a nice table (Thanks Uwe!) about the current status.
>
> Signed-off-by: Patrick Georgi

Wouldn't this cause the warning to be printed multiple times if a
contiguous section is all 0xff?

Regards,
Carl-Daniel

[PATCH]More helpful error if cbfs header magic is 0xffffffff

[Patrick Georgi]

Am 11.11.2009 14:35, schrieb Carl-Daniel Hailfinger:
> Wouldn't this cause the warning to be printed multiple times if a
> contiguous section is all 0xff?

That test merely validates the master header. If that one is wrong, CBFS 
goes boom, without any further lookup.
And even if it printed the message multiple times: This is a panic 
scenario. As long as the message gets out, it's fine.

Patrick

[PATCH]More helpful error if cbfs header magic is 0xffffffff

[Peter Stuge]

Patrick Georgi wrote:
> attached patch hopefully helps track down issues related to late
> enable_rom calls.
>
> Signed-off-by: Patrick Georgi

Acked-by: Peter Stuge