AMD8111_DEV

[Stefan Reinauer]

Hi,

Looking at the config variable AMD8111_DEV I find quite some strange
things:

./mainboard/amd/solo/Config:option AMD8111_DEV=0x5
./mainboard/amd/solo/Config.lb:option AMD8111_DEV=0x3800
./mainboard/amd/quartet/Config:option AMD8111_DEV=0x5
./mainboard/tyan/s2880/Config:option AMD8111_DEV=0x5
./mainboard/tyan/s2880/Config.lb:uses AMD8111_DEV
./mainboard/tyan/s2882/Config:option AMD8111_DEV=0x5
./mainboard/tyan/s2882/Config.lb:uses AMD8111_DEV
./mainboard/tyan/s2885/Config:option AMD8111_DEV=0x5
./mainboard/tyan/s2885/Config.lb:uses AMD8111_DEV
./mainboard/arima/hdama/Config:option AMD8111_DEV=0x5
./mainboard/arima/hdama/Config.lb~:option AMD8111_DEV=0x3800
./mainboard/arima/hdama/Config.lb:uses AMD8111_DEV

It seems to be 5 in some places, and 0x3800 in some obsolete places,
which makes me think that in some config files it is assumed to be
shifted whereas in others it is assumed to contain an already shifted
value.

Same thing here:

./southbridge/amd/amd8111/cmos_boot_failover.inc:       movl $(0x80000000 | AMD8111_DEV | 0x40), %eax
./southbridge/amd/amd8111/amd8111_smbus.c:#define PM_DEVFN (AMD8111_DEVFN+3)
./southbridge/amd/amd8111/smbus.inc:#define PM_DEV_FN (AMD8111_DEV + 0x300)

This should be cleaned up. Any preferences for any variant?

Stefan

[ron minnich]

On Thu, 28 Aug 2003, Stefan Reinauer wrote:
> ./mainboard/amd/solo/Config:option AMD8111_DEV=0x5

if the name is DEV, it should be a device number, not a devfn. If it is a 
device number, it shouldn't be shifted -- that's very confusing for 
people. It should be the device number that lspci shows.

So I prefer 5, and it gets shifted in the macros.

ron