[PATCH] kconfig support for ASUS P2B-F

[Uwe Hermann]

See patch.

Uwe.

[Stefan Reinauer]

On 8/25/09 12:58 AM, Uwe Hermann wrote:
> See patch.
>
> Uwe.
> -- http://www.hermann-uwe.de | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> Add kconfig support for ASUS P2B-F.
>
> Only build-tested so far, not tested on hardware.
>
> Signed-off-by: Uwe Hermann

Acked-by: Stefan Reinauer

[Uwe Hermann]

On Tue, Aug 25, 2009 at 11:15:13AM +0200, Stefan Reinauer wrote:
> > Add kconfig support for ASUS P2B-F.
> >
> > Only build-tested so far, not tested on hardware.
> >
> > Signed-off-by: Uwe Hermann
>
> Acked-by: Stefan Reinauer

Thanks, r4572.

I took the freedom to move the board config from
src/mainboard/asus/Kconfig to src/mainboard/asus/p2b-f/Kconfig
to match the style of the other new Kconfig boards.

Uwe.

[ron minnich]

Now I know why I never write docs .... nobody ever reads them :-)

Index: src/northbridge/intel/i440bx/Makefile.inc
===================================================================
--- src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
+++ src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
@@ -0,0 +1,22 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2009 Uwe Hermann 
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+##
+
+driver-$(CONFIG_NORTHBRIDGE_INTEL_I440BX) += northbridge.o
+
Index: src/northbridge/intel/Makefile.inc
===================================================================
--- src/northbridge/intel/Makefile.inc	(Revision 4566)
+++ src/northbridge/intel/Makefile.inc	(Arbeitskopie)
@@ -2,7 +2,7 @@
 #subdirs-y += e7520
 #subdirs-y += e7525
 #subdirs-y += i3100
-#subdirs-y += i440bx
+subdirs-y += i440bx
 subdirs-y += i82810
 #subdirs-y += i82830
 #subdirs-y += i855gme

This is not quite right. Please change as follows:

Index: src/northbridge/intel/i440bx/Makefile.inc
===================================================================
--- src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
+++ src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
@@ -0,0 +1,22 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2009 Uwe Hermann 
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+##
+
+driver-y += northbridge.o
+
Index: src/northbridge/intel/Makefile.inc
===================================================================
--- src/northbridge/intel/Makefile.inc	(Revision 4566)
+++ src/northbridge/intel/Makefile.inc	(Arbeitskopie)
@@ -2,7 +2,7 @@
 #subdirs-y += e7520
 #subdirs-y += e7525
 #subdirs-y += i3100
-#subdirs-y += i440bx
+subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I440BX) += i440bx
 subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I82810) += i82810
 #subdirs-y += i82830
 #subdirs-y += i855gme

Again, conditional conclusion is at the DIRECTORY level for parts, not
at the FILE level in the actual part directory.

Why do this? It makes is MUCH simpler if you have a part that also
depends on some other variable, such as ACPI configuration variable.

Please change this if you get a chance. Thanks for doing this. It is
really wonderful to see people taking up the Kconfig stuff.

Next I'll introduce my romcc-free qemu stuff ...

ron

[ron minnich]

On Tue, Aug 25, 2009 at 5:26 AM, Uwe Hermann wrote:
> I took the freedom to move the board config from
> src/mainboard/asus/Kconfig to src/mainboard/asus/p2b-f/Kconfig
> to match the style of the other new Kconfig boards.

Wonderful! how does it look to you when you do mainboard selection? As
you would like it to?

ron