See patch. The subject is a bit misleading, since we never used vm86 mode in coreboot.
Stefan
On Tue, 26 May 2009 14:49:42 +0200, Stefan Reinauer stepan@coresystems.de wrote:
See patch. The subject is a bit misleading, since we never used vm86 mode in coreboot.
Great Job Stefan. I really like this, but I would like to test it out before an Ack.
Let's get some testing done but I love this code.
BTW, in this file: + * Erik Arjan Hendriks hendriks@lanl.gov + * Copyright (C) 2000 Scyld. + * Copyright (C) 2000 Scyld Computing Corporation
There's not a single line of code left that was contributed by Erik. What do we do in this case, where the original code is long gone? I used Erik's code for the switch to/from 32-bit mode, but the rest was my stuff copyright 2001.
ron
On Tue, May 26, 2009 at 07:23:06AM -0700, ron minnich wrote:
If the code from one author is gone, the respective copyright line should also be removed, of course.
Uwe.
On Tue, 26 May 2009 14:49:42 +0200, Stefan Reinauer stepan@coresystems.de wrote:
See patch. The subject is a bit misleading, since we never used vm86 mode in coreboot.
Should we rename the option CONFIG_PCI_OPTION_ROM_RUN_VM86 to CONFIG_PCI_OPTION_ROM_RUN_X86 ?
On 29.05.2009 17:59 Uhr, Joseph Smith wrote:
possibly... or "native" or "real_mode" ?
On Sat, 30 May 2009 06:20:12 +0200, Peter Stuge peter@stuge.se wrote:
Already done r4325 and r1170 Renamed to CONFIG_PCI_OPTION_ROM_RUN_REALMODE.