New patch to review for coreboot: c72ad05 Cache 8MB flash instead of 4MB

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/873

-gerrit

commit c72ad05e7b3e38f3366bf37f11adfcc6ce42c36f
Author: Stefan Reinauer 
Date:   Tue Apr 3 16:24:37 2012 -0700

Cache 8MB flash instead of 4MB

Also fix the MTRR check to use the total_mtrrs
    variable instead of a hardcoded 8.

Change-Id: I2c5ceb3910cd949f43ecf5b8aff857d6ffe0b1a5
    Signed-off-by: Duncan Laurie 
---
 src/cpu/x86/mtrr/mtrr.c |   47 +++++++++++++++++++++--------------------------
 1 files changed, 21 insertions(+), 26 deletions(-)

diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c
index ed7d93b..faa0d93 100644
--- a/src/cpu/x86/mtrr/mtrr.c
+++ b/src/cpu/x86/mtrr/mtrr.c
@@ -37,7 +37,6 @@
 #include <cpu/x86/mtrr.h>
 #include <cpu/x86/cache.h>
 #include <cpu/x86/lapic.h>
-#include <arch/cpu.h>
 #include <arch/acpi.h>

#if CONFIG_GFXUMA
@@ -50,6 +49,24 @@ static unsigned int mtrr_msr[] = {
    MTRRfix4K_E0000_MSR, MTRRfix4K_E8000_MSR, MTRRfix4K_F0000_MSR, MTRRfix4K_F8000_MSR,
 };

+/* 2 MTRRS are reserved for the operating system */
+#define BIOS_MTRRS 6
+#define OS_MTRRS   2
+#define MTRRS      (BIOS_MTRRS + OS_MTRRS)
+
+static int total_mtrrs = MTRRS;
+static int bios_mtrrs = BIOS_MTRRS;
+
+static void detect_var_mtrrs(void)
+{
+	msr_t msr;
+
+	msr = rdmsr(MTRRcap_MSR);
+
+	total_mtrrs = msr.lo & 0xff;
+	bios_mtrrs = total_mtrrs - 2;
+}
+
 void enable_fixed_mtrr(void)
 {
    msr_t msr;
@@ -76,8 +93,8 @@ static void set_var_mtrr(
    msr_t base, mask;
    unsigned address_mask_high;

-        if (reg >= 8)
-                return;
+        if (reg >= total_mtrrs)
+               return;

// it is recommended that we disable and enable cache when we
         // do this.
@@ -169,28 +186,6 @@ static inline unsigned int fls(unsigned int x)
  * or a 156MB (128MB + 32MB - 4MB SMA) example:
  *	ramsize = 156MB == 128MB WB (at 0MB) + 32MB WB (at 128MB) + 4MB UC (at 156MB)
  */
-/* 2 MTRRS are reserved for the operating system */
-#if 1
-#define BIOS_MTRRS 6
-#define OS_MTRRS   2
-#else
-#define BIOS_MTRRS 8
-#define OS_MTRRS   0
-#endif
-#define MTRRS        (BIOS_MTRRS + OS_MTRRS)
-
-static int total_mtrrs = MTRRS;
-static int bios_mtrrs = BIOS_MTRRS;
-
-static void detect_var_mtrrs(void)
-{
-	msr_t msr;
-
-	msr = rdmsr(MTRRcap_MSR);
-
-	total_mtrrs = msr.lo & 0xff;
-	bios_mtrrs = total_mtrrs - 2;
-}

static void set_fixed_mtrrs(unsigned int first, unsigned int last, unsigned char type)
 {
@@ -504,7 +499,7 @@ void x86_setup_var_mtrrs(unsigned int address_bits, unsigned int above4gb)
     * complete ROM now that we actually have RAM.
     */
    if (boot_cpu() && (acpi_slp_type != 3)) {
-		set_var_mtrr(total_mtrrs-1, (4096-4)*1024, 4*1024,
+		set_var_mtrr(total_mtrrs-1, (4096-8)*1024, 8*1024,
    		MTRR_TYPE_WRPROT, address_bits);
    }
 #endif