Alexandru Gagniuc (mr.nuke.me@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1474
-gerrit
commit dbdb60fcc546ce3a56e458f3a853f9167b9a7ec2 Author: Alexandru Gagniuc mr.nuke.me@gmail.com Date: Tue Aug 21 17:08:03 2012 -0500
mptable: bring sanity back to mptable generation (TRIVIAL)
Remove extra semicolon Capitalize beginning of printk sentence Fix detection of multiple ISA-carrying IOAPICs
Change-Id: I114119b1daf3b472955c0dd00bdc449401789525 Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com --- src/arch/x86/boot/mpspec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/arch/x86/boot/mpspec.c b/src/arch/x86/boot/mpspec.c index 010bca1..39dcf25 100644 --- a/src/arch/x86/boot/mpspec.c +++ b/src/arch/x86/boot/mpspec.c @@ -443,16 +443,16 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr) ioapic_config->base);
if (ioapic_config->have_isa_interrupts) { - if (isaioapic > 1) + if (isaioapic >= 0) printk(BIOS_ERR, "More than one IOAPIC with ISA interrupts?\n"); else - isaioapic = dev->path.ioapic.ioapic_id;; + isaioapic = dev->path.ioapic.ioapic_id; } }
if (isaioapic >= 0) { /* Legacy Interrupts */ - printk(BIOS_DEBUG, "writing ISA IRQs\n"); + printk(BIOS_DEBUG, "Writing ISA IRQs\n"); mptable_add_isa_interrupts(mc, isa_bus, isaioapic, 0); }