Re: [LinuxBIOS] FW: rev F support code

[Lu, Yinghai]

How about

/*
 * Copyright (C) 2006 ADVANCED MICRO DEVICES
 *
 * This code is under GPL
 *
 * main change log:
 *  
 */

YH

[LinuxBIOS] FW: rev F support code

[Uwe Hermann]

Hi,

On Wed, Oct 04, 2006 at 07:29:40PM -0700, Lu, Yinghai wrote:
> How about
>
> /*
> Copyright (C) 2006 ADVANCED MICRO DEVICES
> This code is under GPL
> main change log:
>
> */

It's better than nothing, but I would rather use the full GPL header,
because that

- includes a "no warranty" phrase
 - explicitly states whether it's "GPL v2" or "GPL v2 or later"
 - is the de-facto standard used in 98% or so of all GPL'd projects

As for the changelog, I don't think that's necessary. That information
is contained in the svn commit logs (at least it should), there's no
need to duplicate it in the files...

HTH, Uwe.

[LinuxBIOS] FW: rev F support code

[Ronald G Minnich]

Uwe Hermann wrote:
> Hi,
>
> On Wed, Oct 04, 2006 at 07:29:40PM -0700, Lu, Yinghai wrote:
> > How about
> >
> > /*
> > Copyright (C) 2006 ADVANCED MICRO DEVICES
> > This code is under GPL
> > main change log:
> >
> > */
>
> It's better than nothing, but I would rather use the full GPL header,
> because that
> includes a "no warranty" phrase
> explicitly states whether it's "GPL v2" or "GPL v2 or later"
> is the de-facto standard used in 98% or so of all GPL'd projects
>
> As for the changelog, I don't think that's necessary. That information
> is contained in the svn commit logs (at least it should), there's no
> need to duplicate it in the files...
>
> HTH, Uwe.

you can include it by reference, see drivers/net:

Copyright 1993 United States Government as represented by the 
Director,
         National Security Agency.  This software may only be used and 
distributed
         according to the terms of the GNU General Public License as 
modified by SRC,
         incorporated herein by reference.
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The key part

if it's good enough for the NSA ...

ron

[LinuxBIOS] FW: rev F support code

[Uwe Hermann]

Hi,

On Fri, Oct 06, 2006 at 08:57:57AM -0600, Ronald G Minnich wrote:
> you can include it by reference, see drivers/net:
>      Copyright 1993 United States Government as represented by the 
>
> Director,
>          National Security Agency.  This software may only be used and 
> distributed
>          according to the terms of the GNU General Public License as 
> modified by SRC,
>          incorporated herein by reference.
>          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> The key part
>
> if it's good enough for the NSA ...

Hm, I don't really understand what the issue is here. I've never seen
this "incorporated herein by reference" being used, but I guess it's
not better or worse than a single line such as

This code is distributed without warranty under the GPL v2 (see COPYING)

which we have in the code already, in a few places.

IMHO the clearest and most common header is the full 10-line or so
version I posted.

Disk space is cheap, cut'n'pasting is fast, so I don't see a reason to
not use it...

Uwe.

[LinuxBIOS] FW: rev F support code

[Ronald G Minnich]

Uwe Hermann wrote:
> Disk space is cheap, cut'n'pasting is fast, so I don't see a reason to
> not use it...

good point.

ron

[LinuxBIOS] FW: rev F support code

[Stefan Reinauer]

* Ronald G Minnich  [061006 20:25]:
> Uwe Hermann wrote:
> > Disk space is cheap, cut'n'pasting is fast, so I don't see a reason to
> > not use it...
>
> good point.

Yes. I suggest we start putting in the patches as soon as someone comes
up with them ;-)

Stefan

[LinuxBIOS] FW: rev F support code

[Segher Boessenkool]

> IMHO the clearest and most common header is the full 10-line or so
> version I posted.
>
> Disk space is cheap, cut'n'pasting is fast, so I don't see a reason to
> not use it...

Just make sure you look at the newest version before you cut'n'paste
it to lots of files (hint: the FSF moved offices some time ago).

Segher

[LinuxBIOS] FW: rev F support code

[Ronald G Minnich]

Segher Boessenkool wrote:
> Just make sure you look at the newest version before you cut'n'paste
> it to lots of files (hint: the FSF moved offices some time ago).

I remember now that's why I like 'by reference'. I've had to change it 
on occasion and it can be a pain.

ron