Patch to extend ROM decode range to 1MB for vt8237r

[bari]

This patch extends the VIA vt8237r southbridge decode range for the ROM 
to 1MB.

Rudolf had use this for a board specific patch in the past. We also already do this for all vt8237r in flashrom.

Signed-off-by: Bari Ari

-Bari

[Peter Stuge]

On Wed, Jun 18, 2008 at 07:21:28PM -0500, bari wrote:
> This patch extends the VIA vt8237r southbridge decode range for the ROM 
> to 1MB.
>
> Rudolf had use this for a board specific patch in the past. We also already 
> do this for all vt8237r in flashrom.
>
> Signed-off-by: Bari Ari

If the TODO is actually still a TODO, please keep the comment.

Acked-by: Peter Stuge
> Index: southbridge/via/vt8237r/vt8237r.c
>
> --- southbridge/via/vt8237r/vt8237r.c	(revision 3368)
> +++ southbridge/via/vt8237r/vt8237r.c	(working copy)
> @@ -78,7 +78,8 @@
>    pci_write_config8(dev, 0x50, sb->fn_ctrl_lo);
>    pci_write_config8(dev, 0x51, sb->fn_ctrl_hi);
> /* TODO: If SATA is disabled, move IDE to fn0 to conform PCI specs. */
> /* Extend ROM decode to 1MB FFC00000 - FFFFFFFF */
> pci_write_config8(dev, 0x41, 0x7f);
>
> }
>
> struct chip_operations southbridge_via_vt8237r_ops = {

[bari]

Peter Stuge wrote:
> On Wed, Jun 18, 2008 at 07:21:28PM -0500, bari wrote:
> > This patch extends the VIA vt8237r southbridge decode range for the ROM 
> > to 1MB.
> >
> > Rudolf had use this for a board specific patch in the past. We also already 
> > do this for all vt8237r in flashrom.
> >
> > Signed-off-by: Bari Ari
>
> If the TODO is actually still a TODO, please keep the comment.
>
> Acked-by: Peter Stuge
> > Index: southbridge/via/vt8237r/vt8237r.c
> >
> > --- southbridge/via/vt8237r/vt8237r.c	(revision 3368)
> > +++ southbridge/via/vt8237r/vt8237r.c	(working copy)
> > @@ -78,7 +78,8 @@
> >    pci_write_config8(dev, 0x50, sb->fn_ctrl_lo);
> >    pci_write_config8(dev, 0x51, sb->fn_ctrl_hi);
> > /* TODO: If SATA is disabled, move IDE to fn0 to conform PCI specs. */
> > /* Extend ROM decode to 1MB FFC00000 - FFFFFFFF */
> > pci_write_config8(dev, 0x41, 0x7f);
> >
> > }
> >
> > struct chip_operations southbridge_via_vt8237r_ops = {

It doesn't matter to me, the SATA comment was there since the thought 
was SATA was broken on vt8237r. If someone wishes to disable the SATA 
then I'd imagine they would handle it in a board specific manner.

Here's another patch with the comment left in.

This patch extends the VIA vt8237r southbridge decode range for the ROM 
to 1MB.

Rudolf had use this for a board specific patch in the past. We also already 
do this for the vt8237r in flashrom.

Signed-off-by: Bari Ari

[Peter Stuge]

On Wed, Jun 18, 2008 at 11:14:32PM -0500, bari wrote:
> This patch extends the VIA vt8237r southbridge decode range for the ROM 
> to 1MB.
>
> Rudolf had use this for a board specific patch in the past. We also already 
> do this for the vt8237r in flashrom.
>
> Signed-off-by: Bari Ari

Acked-by: Peter Stuge
> Index: southbridge/via/vt8237r/vt8237r.c
>
> --- southbridge/via/vt8237r/vt8237r.c	(revision 3368)
> +++ southbridge/via/vt8237r/vt8237r.c	(working copy)
> @@ -78,7 +78,8 @@
>    pci_write_config8(dev, 0x50, sb->fn_ctrl_lo);
>    pci_write_config8(dev, 0x51, sb->fn_ctrl_hi);
>
> /* TODO: If SATA is disabled, move IDE to fn0 to conform PCI specs. */
> /* Extend ROM decode to 1MB FFC00000 - FFFFFFFF */
> pci_write_config8(dev, 0x41, 0x7f);
>
> }
>
> struct chip_operations southbridge_via_vt8237r_ops = {