Re: [coreboot] [v2] r4248 - in trunk/coreboot-v2/src/mainboard: rca/rm4100 thomson/ip1000

[Carl-Daniel Hailfinger]

Hi Joe,

there is a small problem with your commit. Both files has their line
endings (newlines) changed from LF (Unix style) to CR+LF (DOS style).

On 02.05.2009 02:50, [e-mail] wrote:
> Author: linux_junkie
> Date: 2009-05-02 02:50:58 +0200 (Sat, 02 May 2009)
> New Revision: 4248
>
> Modified:
>    trunk/coreboot-v2/src/mainboard/rca/rm4100/gpio.c
>    trunk/coreboot-v2/src/mainboard/thomson/ip1000/gpio.c
> Log:
> Trivial fix up to the GPIO's connected to the IP1000 and RM4100, only set ones that are actually connected to something. 
> Signed-off-by: Joseph Smith  
> Acked-by: Joseph Smith

Almost all files in our tree have LF line terminators. Exceptions are:

CR+LF:
src/southbridge/intel/i82801ca/i82801ca_pci.c
src/northbridge/intel/i82830/vga.c
src/cpu/intel/model_f4x/microcode_MBDF410D.h
src/mainboard/thomson/ip1000/gpio.c
src/mainboard/dell/s1850/irq_tables.c
src/mainboard/rca/rm4100/gpio.c

Mix of CR+LF and LF:
src/mainboard/msi/ms9185/Options.lb
src/mainboard/msi/ms9282/Options.lb
src/mainboard/asus/m2v-mx_se/Options.lb

Regards,
Carl-Daniel

[v2] r4248 - in trunk/coreboot-v2/src/mainboard: rca/rm4100 thomson/ip1000

[Joseph Smith]

On Sat, 02 May 2009 13:46:25 +0200, Carl-Daniel Hailfinger
 wrote:
> Hi Joe,
>
> there is a small problem with your commit. Both files has their line
> endings (newlines) changed from LF (Unix style) to CR+LF (DOS style).
>
> On 02.05.2009 02:50, [e-mail] wrote:
> > Author: linux_junkie
> > Date: 2009-05-02 02:50:58 +0200 (Sat, 02 May 2009)
> > New Revision: 4248
> >
> > Modified:
> >    trunk/coreboot-v2/src/mainboard/rca/rm4100/gpio.c
> >    trunk/coreboot-v2/src/mainboard/thomson/ip1000/gpio.c
> > Log:
> > Trivial fix up to the GPIO's connected to the IP1000 and RM4100, only
>
> set ones that are actually connected to something.
> > Signed-off-by: Joseph Smith 
> > Acked-by: Joseph Smith
>
> Almost all files in our tree have LF line terminators. Exceptions are:
>
> CR+LF:
> src/southbridge/intel/i82801ca/i82801ca_pci.c
> src/northbridge/intel/i82830/vga.c
> src/cpu/intel/model_f4x/microcode_MBDF410D.h
> src/mainboard/thomson/ip1000/gpio.c
> src/mainboard/dell/s1850/irq_tables.c
> src/mainboard/rca/rm4100/gpio.c
>
> Mix of CR+LF and LF:
> src/mainboard/msi/ms9185/Options.lb
> src/mainboard/msi/ms9282/Options.lb
> src/mainboard/asus/m2v-mx_se/Options.lb

I'll have to admit, sometimes when it is slow at work I do use
wordpad/notepad to edit/create files. Unfortunately when I am at work I am
stuck in windows world...