Author: hailfinger Date: 2008-08-22 12:56:36 +0200 (Fri, 22 Aug 2008) New Revision: 799
Modified: coreboot-v3/southbridge/amd/cs5536/smbus_initram.c coreboot-v3/southbridge/nvidia/mcp55/mcp55_smbus.h Log: smbus_delay() performs its own inb(0x80). We can use the generic udelay() instead which does the same, and achieve better abstraction.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net Acked-by: Ronald G. Minnich rminnich@gmail.com
Modified: coreboot-v3/southbridge/amd/cs5536/smbus_initram.c =================================================================== --- coreboot-v3/southbridge/amd/cs5536/smbus_initram.c 2008-08-22 01:22:21 UTC (rev 798) +++ coreboot-v3/southbridge/amd/cs5536/smbus_initram.c 2008-08-22 10:56:36 UTC (rev 799) @@ -69,7 +69,7 @@ */ static void smbus_delay(void) { - /* inb(0x80); */ + /* udelay(1); */ }
/**
Modified: coreboot-v3/southbridge/nvidia/mcp55/mcp55_smbus.h =================================================================== --- coreboot-v3/southbridge/nvidia/mcp55/mcp55_smbus.h 2008-08-22 01:22:21 UTC (rev 798) +++ coreboot-v3/southbridge/nvidia/mcp55/mcp55_smbus.h 2008-08-22 10:56:36 UTC (rev 799) @@ -39,8 +39,7 @@
static inline void smbus_delay(void) { - /* let's hope this is not optimized out */ - (void) inb(0x80); + udelay(1); }
int do_smbus_recv_byte(u16 smbus_io_base, u8 device);