programming 101

[ron minnich]

how the hell did we miss this:
        if (device == DIMM0) {
                for (i = 0; i < ARRAY_SIZE(spd_table); i++) {
                        if (spd_table[i].address == address) {
                                ret = spd_table[i].data;
                        }
                }
        }
        if (i == ARRAY_SIZE(spd_table))
                printk(BIOS_DEBUG, " addr %02x does not exist in SPD table",
                        address);

So, maybe we need a break in there? As it is, it always prints that
things are not found :-)

thanks

ron

[Peter Stuge]

On Wed, Mar 05, 2008 at 07:13:28PM -0800, ron minnich wrote:
> how the hell did we miss this:
>         if (device == DIMM0) {
>                 for (i = 0; i < ARRAY_SIZE(spd_table); i++) {
>                         if (spd_table[i].address == address) {
>                                 ret = spd_table[i].data;
>
> So, maybe we need a break in there?

Or just return instead of ret =

Good find!

//Peter