Re: [LinuxBIOS] r77 - in buildrom-devel: . config/payloads config/platforms packages/linuxbios

[Carl-Daniel Hailfinger]

On 06.12.2007 17:18, [e-mail] wrote:
> Author: jcrouse
> Date: 2007-12-06 17:18:18 +0100 (Thu, 06 Dec 2007)
> New Revision: 77
>
> Log:
> This patch adds support for QEMU to buildrom, for both v2 and v3.  It
> also allows you to build QEMU from sources with the patches.
>
> Signed-off-by: Myles Watson 
> Acked-by: Jordan Crouse
> Modified: buildrom-devel/Config.in
>
> --- buildrom-devel/Config.in	2007-12-05 23:27:08 UTC (rev 76)
> +++ buildrom-devel/Config.in	2007-12-06 16:18:18 UTC (rev 77)
> @@ -43,6 +43,23 @@
>
> menu "LinuxBIOS configuration"
>
> +config LINUXBIOS_V3
> bool "Use LinuxBIOSv3"
> depends ADVANCED
> default n
> help
>  Use the v3 tree.  LinuxBIOSv3 doesn't support all platforms yet.
>
> +config LINUXBIOS_V3_LGDT_PATCH
> bool "Avoid an error in stage0_i586 with some compilers"
> depends LINUXBIOS_V3
> default n
> help
>  Say 'y' here to use the patch from the mailing list to replace 
>  "data32  lgdt %cs:gdtptr" with 
>  "movl $gdtptr"
>      "%ebx lgdt %cs:(%bx)"
>
> config USE_LZMA
>    bool "Enable LZMA compression"
>    depends !PAYLOAD_OFW

While I welcome almost everything in that patch, I dislike that part.
Either we agree on some code sequence that works for everyone or we mark
some compilers "broken".

Regards,
Carl-Daniel

[LinuxBIOS] r77 - in buildrom-devel: . config/payloads config/platforms packages/linuxbios

[Myles Watson]

> > Modified: buildrom-devel/Config.in
> >
> > --- buildrom-devel/Config.in	2007-12-05 23:27:08 UTC (rev 76)
> > +++ buildrom-devel/Config.in	2007-12-06 16:18:18 UTC (rev 77)
> > @@ -43,6 +43,23 @@
> >
> > menu "LinuxBIOS configuration"
> >
> > +config LINUXBIOS_V3
> > bool "Use LinuxBIOSv3"
> > depends ADVANCED
> > default n
> > help
> >  Use the v3 tree.  LinuxBIOSv3 doesn't support all platforms yet.
> >
> > +config LINUXBIOS_V3_LGDT_PATCH
> > bool "Avoid an error in stage0_i586 with some compilers"
> > depends LINUXBIOS_V3
> > default n
> > help
> >  Say 'y' here to use the patch from the mailing list to replace
> >  "data32  lgdt %cs:gdtptr" with
> >  "movl $gdtptr"
> >      "%ebx lgdt %cs:(%bx)"
> >
> > config USE_LZMA
> >    bool "Enable LZMA compression"
> >    depends !PAYLOAD_OFW
>
> While I welcome almost everything in that patch, I dislike that part.
> Either we agree on some code sequence that works for everyone or we mark
> some compilers "broken".

I like the "code sequence that works for everyone" thought.  That's more of
a LinuxBIOSv3 issue than a buildrom issue, though.  I'd hoped to make people
happy by not applying the patch by default.

Myles

[LinuxBIOS] r77 - in buildrom-devel: . config/payloads config/platforms packages/linuxbios

[Carl-Daniel Hailfinger]

On 06.12.2007 17:33, Myles Watson wrote:
> > > Modified: buildrom-devel/Config.in
> > >
> > > --- buildrom-devel/Config.in	2007-12-05 23:27:08 UTC (rev 76)
> > > +++ buildrom-devel/Config.in	2007-12-06 16:18:18 UTC (rev 77)
> > > @@ -43,6 +43,23 @@
> > >
> > > menu "LinuxBIOS configuration"
> > >
> > > +config LINUXBIOS_V3
> > > bool "Use LinuxBIOSv3"
> > > depends ADVANCED
> > > default n
> > > help
> > >  Use the v3 tree.  LinuxBIOSv3 doesn't support all platforms yet.
> > >
> > > +config LINUXBIOS_V3_LGDT_PATCH
> > > bool "Avoid an error in stage0_i586 with some compilers"
> > > depends LINUXBIOS_V3
> > > default n
> > > help
> > >  Say 'y' here to use the patch from the mailing list to replace
> > >  "data32  lgdt %cs:gdtptr" with
> > >  "movl $gdtptr"
> > >      "%ebx lgdt %cs:(%bx)"
> > >
> > > config USE_LZMA
> > >    bool "Enable LZMA compression"
> > >    depends !PAYLOAD_OFW
> >
> > While I welcome almost everything in that patch, I dislike that part.
> > Either we agree on some code sequence that works for everyone or we mark
> > some compilers "broken".
>
> I like the "code sequence that works for everyone" thought.  That's more of
> a LinuxBIOSv3 issue than a buildrom issue, though.  I'd hoped to make people
> happy by not applying the patch by default.

Can you send it in as a patch with a short description? If comments are
positive, we should just commit.

Regards,
Carl-Daniel