[PATCH]: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[Uwe Hermann]

See patch.

Uwe.

[PATCH]: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[Marc Jones]

> Move AMD RS690 and SB600 PCI IDs to pci_ids.h where they should be.
>
> Build-tested with the AMD dbm690t board.
>
> Signed-off-by: Uwe Hermann

Acked-by: Marc Jones

[PATCH]: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[Uwe Hermann]

On Mon, Oct 13, 2008 at 02:50:05PM -0600, Marc Jones wrote:
> > Move AMD RS690 and SB600 PCI IDs to pci_ids.h where they should be.
> >
> > Build-tested with the AMD dbm690t board.
> >
> > Signed-off-by: Uwe Hermann
>
> Acked-by: Marc Jones

Thanks, r3655.

Btw, should PCI_DEVICE_ID_ATI* be renamed to PCI_DEVICE_ID_AMD*
for the RS690 and SB600? Or should we keep the old names?

Uwe.

[PATCH]: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[Marc Jones]

Uwe Hermann wrote:
> On Mon, Oct 13, 2008 at 02:50:05PM -0600, Marc Jones wrote:
> > > Move AMD RS690 and SB600 PCI IDs to pci_ids.h where they should be.
> > >
> > > Build-tested with the AMD dbm690t board.
> > >
> > > Signed-off-by: Uwe Hermann
> >
> > Acked-by: Marc Jones
>
> Thanks, r3655.
>
> Btw, should PCI_DEVICE_ID_ATI* be renamed to PCI_DEVICE_ID_AMD*
> for the RS690 and SB600? Or should we keep the old names?

Yes you are correct. We should change that.
Thanks,
Marc

[PATCH]: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[ron minnich]

patch for v3 would be appreciated.

ron

: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[Jordan Crouse]

On 13/10/08 16:07 -0600, Marc Jones wrote:
> Uwe Hermann wrote:
> > On Mon, Oct 13, 2008 at 02:50:05PM -0600, Marc Jones wrote:
> > > > Move AMD RS690 and SB600 PCI IDs to pci_ids.h where they should be.
> > > >
> > > > Build-tested with the AMD dbm690t board.
> > > >
> > > > Signed-off-by: Uwe Hermann
> > >
> > > Acked-by: Marc Jones
> >
> > Thanks, r3655.
> >
> > Btw, should PCI_DEVICE_ID_ATI* be renamed to PCI_DEVICE_ID_AMD*
> > for the RS690 and SB600? Or should we keep the old names?
>
> Yes you are correct. We should change that.

I disagree - the vendor ID is still 0x1002 which is technically assigned
to ATI - the kernel has always had the policy of matching the vendor ID
to the assignee of the number, not the current owner of the IP.  As an
example, note that the CS5535 IDs in the kernel are still tagged with
VENDOR_NSC.

I think we should keep the old names so that they match the vendor ID.

Jordan

: v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h

[ron minnich]

On Tue, Oct 14, 2008 at 7:35 AM, Jordan Crouse  wrote:
> I disagree - the vendor ID is still 0x1002 which is technically assigned
> to ATI - the kernel has always had the policy of matching the vendor ID
> to the assignee of the number, not the current owner of the IP.  As an
> example, note that the CS5535 IDs in the kernel are still tagged with
> VENDOR_NSC.
>
> I think we should keep the old names so that they match the vendor ID.

yep. if the vendor ID is ATI, don't change it.

ron