#109: flash base autodetection on AMD SC520 ----------------------------------+----------------------------------------- Reporter: stepan | Owner: stepan Type: defect | Status: new Priority: major | Milestone: Component: adlo | Version: v2 Keywords: | Dependencies: Patchstatus: patch needs review | ----------------------------------+----------------------------------------- this code has been sitting on my hard disk for a while. It drops the nasty ifdefs and implements auto detection for AMD SC520 systems, such as the Technologic Systems TS5300.
#109: flash base autodetection on AMD SC520 -------------------------+-------------------------------------------------- Reporter: stepan | Owner: stepan Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: Dependencies: | Patchstatus: patch needs review -------------------------+-------------------------------------------------- Changes (by stepan):
* version: v2 => * component: adlo => flashrom * milestone: => flashrom v1.0
#109: flash base autodetection on AMD SC520 -------------------------+-------------------------------------------------- Reporter: stepan | Owner: stepan Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: Dependencies: | Patchstatus: patch needs work -------------------------+-------------------------------------------------- Changes (by hailfinger):
* patchstatus: patch needs review => patch needs work
Comment:
Sorry, trac didn't mail the attachment to the list, so I was unaware of it.
If possible, please move all code inside the if (pci_dev_find(0x1022, 0x3000) != NULL) to chipset_enable.c and have it set a global variable is_elan=true and another variable elan_baseaddr. That way, we can keep the main flashrom loop mostly free of chipset/processor dependent stuff. I'm open to variants of the above, though, as long as code is moved to chipset_enable.c.
#109: flash base autodetection on AMD SC520 -------------------------+-------------------------------------------------- Reporter: stepan | Owner: stepan Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: Dependencies: | Patchstatus: patch needs work -------------------------+--------------------------------------------------
Comment(by hailfinger):
The new code is very readable and upon moving it to chipset_enable.c, it is
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
#109: flash base autodetection on AMD SC520 -------------------------+-------------------------------------------------- Reporter: stepan | Owner: stepan Type: defect | Status: closed Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: fixed | Keywords: Dependencies: | Patchstatus: patch has been committed -------------------------+-------------------------------------------------- Changes (by stuge):
* status: new => closed * patchstatus: patch needs work => patch has been committed * resolution: => fixed
Comment:
r3790
-
coreboot