Patch attached.
-Corey
Am Donnerstag, den 29.07.2010, 03:08 -0400 schrieb Corey Osgood:
Add support for the Intel Atom D400/500- and N400-series integrated northbridge. Also add support for the very similar Q963/965 northbridge. Tested: D510: confirmed working, with MCHBAR enable code Q965: writes to bit 0 to enable MCHBAR access are ignored, all other functions work
Untested: D410/D525/N400: should be the same northbridge
Maybe add a link to the datasheets to the commit message.
Signed-off-by: Corey Osgood corey.osgood@gmail.com
Acked-by: Paul Menzel paulepanter@users.sourceforge.net
If you want to you could add full stops add the end of sentences.
[…]
Index: memory.c
--- memory.c (revision 5670) +++ memory.c (working copy) @@ -47,6 +47,32 @@ mchbar_phys = pci_read_long(nb, 0x48) & 0xfffffffe; mchbar_phys |= ((uint64_t)pci_read_long(nb, 0x4c)) << 32; break;
case PCI_DEVICE_ID_INTEL_Q965:
case PCI_DEVICE_ID_INTEL_ATOM_DXXX:
case PCI_DEVICE_ID_INTEL_ATOM_NXXX:
mchbar_phys = pci_read_long(nb, 0x48);
/* Test if bit 0 of the MCHBAR reg is 1 to enable memory reads.
* If it isn't, try to set it. This may fail, because there is
* some bit that locks that bit, and isn't in the public
* datasheets.
*/
if(!(mchbar_phys & 1))
{
printf("Access to the MCHBAR is currently disabled, "\
"attempting to enable\n");
Full stop at the end of the sentence.
mchbar_phys |= 0x1;
pci_write_long(nb, 0x48, mchbar_phys);
mchbar_phys = pci_read_long(nb, 0x48);
if(pci_read_long(nb, 0x48) & 1)
printf("Enabled successfully\n");
Dito.
else
printf("Enable FAILED!\n");
}
mchbar_phys &= 0xfffffffe;
mchbar_phys |= ((uint64_t)pci_read_long(nb, 0x4c)) << 32;
break; case PCI_DEVICE_ID_INTEL_82443LX: case PCI_DEVICE_ID_INTEL_82443BX: case PCI_DEVICE_ID_INTEL_82810:
[…]
On 7/29/10 9:08 AM, Corey Osgood wrote:
Add support for the Intel Atom D400/500- and N400-series integrated northbridge. Also add support for the very similar Q963/965 northbridge. Tested: D510: confirmed working, with MCHBAR enable code Q965: writes to bit 0 to enable MCHBAR access are ignored, all other functions work
Untested: D410/D525/N400: should be the same northbridge
Signed-off-by: Corey Osgood corey.osgood@gmail.com
Great! Got to try this on my Pineview ref board.
Acked-by: Stefan Reinauer stepan@coresystems.de
Stefan
Is there a good ref. board to buy to try it out?
ron
On 7/29/10 8:10 PM, ron minnich wrote:
Is there a good ref. board to buy to try it out?
ron
The Intel Seed Board Program is a good place to get them if you have an Intel NDA. http://edc.intel.com/Platforms/Seed-Board-Program/ I got the Advantech AIMB-212 N450 Board. The board is nice, got no comparison though.
Stefan
Committed, r5673, with a couple minor changes (remove an unnecessary read, add full stops).
Thanks, Corey
On Thu, Jul 29, 2010 at 3:12 PM, Stefan Reinauer stefan.reinauer@coresystems.de wrote:
On 7/29/10 8:10 PM, ron minnich wrote:
Is there a good ref. board to buy to try it out?
ron
The Intel Seed Board Program is a good place to get them if you have an Intel NDA. http://edc.intel.com/Platforms/Seed-Board-Program/ I got the Advantech AIMB-212 N450 Board. The board is nice, got no comparison though.
Stefan
-- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Thu, Jul 29, 2010 at 11:10 AM, ron minnich rminnich@gmail.com wrote:
Is there a good ref. board to buy to try it out?
The Zotan NM-10 DTX board has 2 PCI-E ports (one x16 one x1), a mini-PCI-E, 2 DDR2 slots, a serial header, and socketed SPI flash, which is why I chose it. Oh, and everyone on the Zotac forums complains about the buggy stock BIOS :)
-Corey