[commit] r5243 - in trunk/src: mainboard/rca/rm4100 mainboard/thomson/ip1000 northbridge/intel/i82830

[repository service]

Author: stepan
Date: Wed Mar 17 04:18:29 2010
New Revision: 5243
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5243

Log:
This is kind of a pre CAR patch to properly allocate "shared" graphics memory
area.

CONFIG_GFXUMA is used in src/cpu/x86/mtrr/mtrr.c which is called by the cpu.

Attached is a revised patch which works well.

Signed-off-by: Joseph Smith 
Acked-by: Stefan Reinauer

See boot snips below:

Root Device assign_resources, bus 0 link: 0
8MB IGD UMA
Available memory: 581632KB
PCI_DOMAIN: 0000 assign_resources, bus 0 link: 0
----------------------------
Adding high table area
Adding UMA memory area
coreboot memory table:
 0. 0000000000000000-0000000000000fff: CONFIGURATION TABLES
 1. 0000000000001000-000000000009ffff: RAM
 2. 0000000000100000-00000000237effff: RAM
 3. 00000000237f0000-00000000237fffff: CONFIGURATION TABLES
 4. 0000000023800000-0000000023ffffff: RESERVED

Modified:
   trunk/src/mainboard/rca/rm4100/Kconfig
   trunk/src/mainboard/rca/rm4100/mainboard.c
   trunk/src/mainboard/thomson/ip1000/Kconfig
   trunk/src/mainboard/thomson/ip1000/mainboard.c
   trunk/src/northbridge/intel/i82830/northbridge.c
   trunk/src/northbridge/intel/i82830/raminit.c

Modified: trunk/src/mainboard/rca/rm4100/Kconfig
==============================================================================
--- trunk/src/mainboard/rca/rm4100/Kconfig	Wed Mar 17 04:14:54 2010	(r5242)
+++ trunk/src/mainboard/rca/rm4100/Kconfig	Wed Mar 17 04:18:29 2010	(r5243)
@@ -8,9 +8,11 @@
    select ROMCC
    select HAVE_PIRQ_TABLE
    select UDELAY_TSC
-	select BOARD_ROMSIZE_KB_512
+ 	select BOARD_ROMSIZE_KB_1024
+ 	select HAVE_MAINBOARD_RESOURCES
    select HAVE_HARD_RESET
    select HAVE_SMI_HANDLER
+ 	select GFXUMA

config MAINBOARD_DIR
    string

Modified: trunk/src/mainboard/rca/rm4100/mainboard.c
==============================================================================
--- trunk/src/mainboard/rca/rm4100/mainboard.c	Wed Mar 17 04:14:54 2010	(r5242)
+++ trunk/src/mainboard/rca/rm4100/mainboard.c	Wed Mar 17 04:18:29 2010	(r5243)
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2008 Joseph Smith 
+ * Copyright (C) 2008-2010 Joseph Smith 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,8 +19,15 @@
  */

#include <device/device.h>
+#include <boot/tables.h>
+#include <arch/coreboot_tables.h>
 #include "chip.h"

+int add_mainboard_resources(struct lb_memory *mem)
+{
+	return add_northbridge_resources(mem);
+}
+
 static void mainboard_init(device_t dev)
 {
    // TODO Switch parport LEDs again

Modified: trunk/src/mainboard/thomson/ip1000/Kconfig
==============================================================================
--- trunk/src/mainboard/thomson/ip1000/Kconfig	Wed Mar 17 04:14:54 2010	(r5242)
+++ trunk/src/mainboard/thomson/ip1000/Kconfig	Wed Mar 17 04:18:29 2010	(r5243)
@@ -10,7 +10,9 @@
    select UDELAY_TSC
    select BOARD_ROMSIZE_KB_512
    select HAVE_HARD_RESET
+	select HAVE_MAINBOARD_RESOURCES
    select HAVE_SMI_HANDLER
+	select GFXUMA

config MAINBOARD_DIR
    string

Modified: trunk/src/mainboard/thomson/ip1000/mainboard.c
==============================================================================
--- trunk/src/mainboard/thomson/ip1000/mainboard.c	Wed Mar 17 04:14:54 2010	(r5242)
+++ trunk/src/mainboard/thomson/ip1000/mainboard.c	Wed Mar 17 04:18:29 2010	(r5243)
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2008 Joseph Smith 
+ * Copyright (C) 2008-2010 Joseph Smith 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,8 +19,15 @@
  */

#include <device/device.h>
+#include <boot/tables.h>
+#include <arch/coreboot_tables.h>
 #include "chip.h"

+int add_mainboard_resources(struct lb_memory *mem)
+{
+	return add_northbridge_resources(mem);
+}
+
 static void mainboard_init(device_t dev)
 {
    // TODO Switch parport LEDs again

Modified: trunk/src/northbridge/intel/i82830/northbridge.c
==============================================================================
--- trunk/src/northbridge/intel/i82830/northbridge.c	Wed Mar 17 04:14:54 2010	(r5242)
+++ trunk/src/northbridge/intel/i82830/northbridge.c	Wed Mar 17 04:18:29 2010	(r5243)
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2008 Joseph Smith 
+ * Copyright (C) 2008-2010 Joseph Smith 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -28,6 +28,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <bitops.h>
+#include <boot/tables.h>
+#include <arch/coreboot_tables.h>
 #include "chip.h"
 #include "i82830.h"

@@ -88,6 +90,18 @@
    return tolm;
 }

+/* IGD memory */
+uint64_t uma_memory_base=0, uma_memory_size=0;
+
+int add_northbridge_resources(struct lb_memory *mem)
+{
+	printk_debug("Adding IGD UMA memory area\n");
+	lb_add_memory_range(mem, LB_MEM_RESERVED,
+		uma_memory_base, uma_memory_size);
+
+	return 0;
+}
+
 #if CONFIG_WRITE_HIGH_TABLES==1
 #define HIGH_TABLES_SIZE 64	// maximum size of high tables in KB
 extern uint64_t high_tables_base, high_tables_size;
@@ -106,8 +120,10 @@

if (CONFIG_VIDEO_MB == 512) {
    		igd_memory = (CONFIG_VIDEO_MB);
+			printk_debug("%dKB IGD UMA\n", igd_memory >> 10);
    	} else {
    		igd_memory = (CONFIG_VIDEO_MB * 1024);
+			printk_debug("%dMB IGD UMA\n", igd_memory >> 10);
    	}

/* Get the value of the highest DRB. This tells the end of
@@ -116,7 +132,11 @@
    	 */
    	tomk = ((unsigned long)pci_read_config8(mc_dev, DRB + 3)) << 15;
    	tomk -= igd_memory;
-		printk_debug("Memory detected: %ldKB RAM\n", tomk);
+
+		/* For reserving UMA memory in the memory map */
+		uma_memory_base = tomk * 1024ULL;
+		uma_memory_size = igd_memory * 1024ULL;
+		printk_debug("Available memory: %ldKB\n", tomk);

/* Compute the top of low memory. */
    	tolmk = pci_tolm >> 10;

Modified: trunk/src/northbridge/intel/i82830/raminit.c
==============================================================================
--- trunk/src/northbridge/intel/i82830/raminit.c	Wed Mar 17 04:14:54 2010	(r5242)
+++ trunk/src/northbridge/intel/i82830/raminit.c	Wed Mar 17 04:18:29 2010	(r5243)
@@ -48,7 +48,7 @@
  * 0x0 for Refresh Disabled (Self Refresh)
  * 0x1 for Refresh interval 15.6 us for 133MHz
  * 0x2 for Refresh interval 7.8 us for 133MHz
- * 0x7 /* Refresh interval 128 Clocks. (Fast Refresh Mode)
+ * 0x7 for Refresh interval 128 Clocks. (Fast Refresh Mode)
  */
 #define RAM_COMMAND_REFRESH		0x1

[commit] r5243 - in trunk/src: mainboard/rca/rm4100 mainboard/thomson/ip1000 northbridge/intel/i82830

[Joseph Smith]

On 03/16/2010 11:18 PM, repository service wrote:
> Author: stepan
> Date: Wed Mar 17 04:18:29 2010
> New Revision: 5243
> URL: https://tracker.coreboot.org/trac/coreboot/changeset/5243
>
> Log:
> This is kind of a pre CAR patch to properly allocate "shared" graphics memory
> area.
>
> CONFIG_GFXUMA is used in src/cpu/x86/mtrr/mtrr.c which is called by the cpu.
>
> Attached is a revised patch which works well.
>
> Signed-off-by: Joseph Smith
> Acked-by: Stefan Reinauer

Thanks :-)