Patch merged into coreboot/master: 9f7c092 libpayload: remove uhci_reg_maskX - coreboot

24 Dec 2011


      the following patch was just integrated into master:
commit 9f7c092cc6dc9101fcc3db20914b0efb69686e84
Author: Patrick Georgi patrick.georgi@secunet.com
Date:   Fri Nov 18 14:44:16 2011 +0100
libpayload: remove uhci_reg_maskX
Not that good an idea to start with.
Coccinelle patch:
    @@
    @@
    -void
    (
    -uhci_reg_mask8
    |
    -uhci_reg_mask16
    |
    -uhci_reg_mask32
    )
    - (...) { ... }
@@
    @@
    -void
    (
    -uhci_reg_mask8
    |
    -uhci_reg_mask16
    |
    -uhci_reg_mask32
    )
    - (...);
@@
    expression ctrl, reg, ormask;
    @@
    -uhci_reg_mask32 (ctrl, reg, ~0, ormask)
    +uhci_reg_write32 (ctrl, reg, uhci_reg_read32 (ctrl, reg) | ormask)
@@
    expression ctrl, reg, ormask;
    @@
    -uhci_reg_mask16 (ctrl, reg, ~0, ormask)
    +uhci_reg_write16 (ctrl, reg, uhci_reg_read16 (ctrl, reg) | ormask)
@@
    expression ctrl, reg, ormask;
    @@
    -uhci_reg_mask8 (ctrl, reg, ~0, ormask)
    +uhci_reg_write8 (ctrl, reg, uhci_reg_read8 (ctrl, reg) | ormask)
@@
    expression ctrl, reg, andmask;
    @@
    -uhci_reg_mask32 (ctrl, reg, andmask, 0)
    +uhci_reg_write32 (ctrl, reg, uhci_reg_read32 (ctrl, reg) & andmask)
@@
    expression ctrl, reg, andmask;
    @@
    -uhci_reg_mask16 (ctrl, reg, andmask, 0)
    +uhci_reg_write16 (ctrl, reg, uhci_reg_read16 (ctrl, reg) & andmask)
@@
    expression ctrl, reg, andmask;
    @@
    -uhci_reg_mask16 (ctrl, reg, andmask, 0)
    +uhci_reg_write16 (ctrl, reg, uhci_reg_read16 (ctrl, reg) & andmask)
Change-Id: Id0eb8327293831e54249d43fd06d50963c793699
    Signed-off-by: Patrick Georgi patrick.georgi@secunet.com
See http://review.coreboot.org/477 for details.
-gerrit