Re: [coreboot] Enable USB Debug Device!

[Myles Watson]

On Tue, Aug 3, 2010 at 4:39 PM,   wrote:
> Hello,
>
> I bought the “PLX NET20DC USB Debug Device”.
>
> Now I want to use this device for debug purpose. But I get with different
> mainboards the same build error messages.
>
> Can anybody help?
> cc1: warnings being treated as errors

We've made warnings errors since this code has been used much.  You
can change the default value for WARNINGS_ARE_ERRORS in src/Kconfig to
n, make oldconfig, and try building again.  It's a bonus if you fix
the warnings and submit a patch :)

Thanks,
Myles

Enable USB Debug Device!

[Myles Watson]

On Wed, Aug 4, 2010 at 9:15 AM, Myles Watson  wrote:
> On Tue, Aug 3, 2010 at 4:39 PM,   wrote:
> > Hello,
> >
> > I bought the “PLX NET20DC USB Debug Device”.
> >
> > Now I want to use this device for debug purpose. But I get with different
> > mainboards the same build error messages.
> >
> > Can anybody help?
> > cc1: warnings being treated as errors
>
> We've made warnings errors since this code has been used much.  You
> can change the default value for WARNINGS_ARE_ERRORS in src/Kconfig to
> n, make oldconfig, and try building again.  It's a bonus if you fix
> the warnings and submit a patch :)

Here's a (mostly trivial) patch that fixes the warnings.  Abuild
tested with USBDEBUG enabled.

Signed-off-by: Myles Watson

Thanks,
Myles

Enable USB Debug Device!

[Myles Watson]

And the patch.

Signed-off-by: Myles Watson

Thanks,
Myles

Enable USB Debug Device!

[Stefan Reinauer]

On 8/4/10 8:00 PM, Myles Watson wrote:
> And the patch.
>
> Signed-off-by: Myles Watson

Acked-by: Stefan Reinauer

Enable USB Debug Device!

[Myles Watson]

On Wed, Aug 4, 2010 at 1:20 PM, Stefan Reinauer
 wrote:
> On 8/4/10 8:00 PM, Myles Watson wrote:
> > And the patch.
> >
> > Signed-off-by: Myles Watson
>
> Acked-by: Stefan Reinauer

Rev 5683.

Thanks,
Myles