Mathias Krause (mathias.krause@secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/616
-gerrit
commit ec43d3821cc94bc7d600ed8e63d903196160d1c7 Author: Mathias Krause mathias.krause@secunet.com Date: Wed Feb 8 10:31:42 2012 +0100
libpayload: fix possible mem leak in get_option_as_string()
Change-Id: I7c3adbd1b72be81585bbaabb42532fc4cad57f58 Signed-off-by: Mathias Krause mathias.krause@secunet.com --- payloads/libpayload/drivers/options.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index 10d165e..8161c22 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -292,7 +292,7 @@ int get_option_as_string(const struct nvram_accessor *nvram, struct cb_cmos_opti *dest = strdup((const char*)cmos_enum->text); break; default: /* fail */ - return 1; + ret = 1; } free(raw); return ret;