[LinuxBIOS] patch: post code standard

[ron minnich]

comments welcome.

ron

[Peter Stuge]

On Mon, Nov 26, 2007 at 03:02:00PM -0800, ron minnich wrote:
> comments welcome.

I would very much like this file to have the codes in chronological
order. Maybe put global stuff like FATAL_ERROR first?

//Peter

[Uwe Hermann]

On Mon, Nov 26, 2007 at 03:02:00PM -0800, ron minnich wrote:
> comments welcome.
>
> ron
> Proposed start of standard post codes. 
> Signed-off-by: Ronald G. Minnich
> Index: include/post_code.h
>
> --- include/post_code.h	(revision 521)
> +++ include/post_code.h	(working copy)
> @@ -25,6 +25,11 @@
>
> SHARED(post_code, void, u8 value);
>
> -#define POST_START_OF_MAIN                              0x01
> +#define POST_FATAL_ERROR			0xff

Maybe this should not be 0xff or 0x00, as dummy/tests/errors might also
produce 0x00 or 0xff? Maybe 0xfe or something to distringuish it from
other random problems in the (hardware) setup?
> +#define POST_CAR_BASE				0x03

What is this? When is it used? I think each (or most) POST codes should
have a comment here.
> +#define POST_STAGE1_BASE			0x10
> +#define POST_STAGE2_BASE			0x20

I like the names here.
> +/* BOGUS! */
> +#define POST_START_OF_MAIN			0x01
>
> #endif /* POST_CODE_H */

I agree with Peter that a chronological order might be good. _And_ the
chronological order should (mostly at least) match the numbers, i.e.
higher numbers appear later in the boot process.

Uwe.