[v3][patch] Fix stdcall for asm to C call.

[Marc Jones]

Coreboot uses the compiler option -mregparm=3 which causes variables to be
passed in registers. This is good for size and speed but not good when we
call a C function from asm. Force stage1_phase1 to use stdcall and get
variables off the stack.

Note that I didn't change stage1_phase3 because it doesn't use any variables.

Signed-off-by: Marc Jones

[Carl-Daniel Hailfinger]

On 06.02.2009 23:34, Marc Jones wrote:
> Coreboot uses the compiler option -mregparm=3 which causes variables to be
> passed in registers. This is good for size and speed but not good when we
> call a C function from asm. Force stage1_phase1 to use stdcall and get
> variables off the stack.
>
> Note that I didn't change stage1_phase3 because it doesn't use any variables.
>
> Signed-off-by: Marc Jones

Yes please! This is exactly the patch I sent months ago. There were
claims that it broke the Kontron board, but I doubt that. Back then,
nobody was willing to test, so the whole stage0/stage1 handoff patches
were reverted.
Oh, and the intel x86 handoff is wrong, but my fix for that was reverted
as well.

If we fix the buggy intel x86 stage0 code again, this is
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Peter Stuge]

Marc Jones wrote:
> Coreboot uses the compiler option -mregparm=3 which causes variables to be
> passed in registers. This is good for size and speed but not good when we
> call a C function from asm. Force stage1_phase1 to use stdcall and get
> variables off the stack.
>
> Note that I didn't change stage1_phase3 because it doesn't use any variables.
>
> Signed-off-by: Marc Jones

Acked-by: Peter Stuge

[Marc Jones]

On Fri, Feb 6, 2009 at 4:27 PM, Peter Stuge  wrote:
> Marc Jones wrote:
> > Coreboot uses the compiler option -mregparm=3 which causes variables to be
> > passed in registers. This is good for size and speed but not good when we
> > call a C function from asm. Force stage1_phase1 to use stdcall and get
> > variables off the stack.
> >
> > Note that I didn't change stage1_phase3 because it doesn't use any variables.
> >
> > Signed-off-by: Marc Jones
>
> Acked-by: Peter Stuge

r1127