[LinuxBIOS] [PATCH] SPD functions refactoring

[Uwe Hermann]

First off: please do _not_ apply this patch. Thanks ;-)

This moves all/most generic SPD-only functions (which are not
chipset-specific) into an extra spd.c file. The second step would be to
merge all near-identical functions into one generic version which all
chipsets can use.

This is _not_ a working patch, yet, it's merely here to illustrate what
I'm working on.

I repeat:
 - This should _not_ be committed in this form.
 - It probably doesn't compile and breaks a ton of boards
 - It's not yet abuild-tested
 - It's not tested on real hardware
 - It's incomplete

Preliminary comments are welcome, though...

Uwe.

[Peter Stuge]

On Tue, May 15, 2007 at 10:38:43PM +0200, Uwe Hermann wrote:
> This moves all/most generic SPD-only functions (which are not
> chipset-specific) into an extra spd.c file.

I like.

//Peter

Quoting Uwe Hermann :
> First off: please do _not_ apply this patch. Thanks ;-)
>
> This moves all/most generic SPD-only functions (which are not
> chipset-specific) into an extra spd.c file. The second step would be to
> merge all near-identical functions into one generic version which all
> chipsets can use.
>
> This is _not_ a working patch, yet, it's merely here to illustrate what
> I'm working on.
>
> I repeat:
> This should _not_ be committed in this form.
> It probably doesn't compile and breaks a ton of boards
> It's not yet abuild-tested
> It's not tested on real hardware
> It's incomplete
>
> Preliminary comments are welcome, though...
> Uwe.

Uwe,
I think this is a great idea! But, should there be one for SDRAM and  
one for DDR maybe??

Thanks - Joe

[Uwe Hermann]

On Wed, May 16, 2007 at 04:43:11AM -0400, [e-mail] wrote:
> I think this is a great idea! But, should there be one for SDRAM and  
> one for DDR maybe??

Nope, I think all should go into one spd.c file, and ideally the
functions should handle SDRAM/DDR/whatever correctly (some already do to
a certain extent, I think).

Don't be confused by the sdram/ directory name, I just used it because
it's already there and I didn't want to introduce yet another one. The
code is not necessarily SDRAM-specific.

Uwe.