Re: [coreboot] gerrit: patch iterations in email [was: differences between patchset iterations]

[Uwe Hermann]

On Wed, Jun 08, 2011 at 07:24:39PM -0700, David Hendricks wrote:
> On Wed, Jun 8, 2011 at 5:16 PM, Peter Stuge  wrote:
> > Paul Menzel wrote:
> > > > http://review.coreboot.org/12
> > >
> > > opening that URL I see that Sven uploaded a second iteration.
> >
> > I think I would like to get later iterations in follow-up emails..

Yep, me too.
> If you add yourself as a reviewer, you should get e-mails for comments and
> iterations.
>
> (Note: I haven't verified this with Coreboot's gerrit setup)

I'd prefer to see all changes for all issues on the mailing list, I don't
think I want to go to the web interface for every new patch submission
someone does and add myself there just in order to get the notifications.

Uwe.

gerrit: patch iterations in email [was: differences between patchset iterations]

[David Hendricks]

On Thu, Jun 9, 2011 at 9:39 AM, Uwe Hermann  wrote:
> On Wed, Jun 08, 2011 at 07:24:39PM -0700, David Hendricks wrote:
> > On Wed, Jun 8, 2011 at 5:16 PM, Peter Stuge  wrote:
> > > Paul Menzel wrote:
> > > > > http://review.coreboot.org/12
> > > >
> > > > opening that URL I see that Sven uploaded a second iteration.
> > >
> > > I think I would like to get later iterations in follow-up emails..
>
> Yep, me too.

Maybe I was over-reacting to what seemed like a lot of "Patch set updated"
e-mails drowning out ML discussion.

Perhaps it would be wise to create another e-mail list for verbose gerrit
messages? That could satisfy the needs of the more involved developers,
without creating too much traffic on the main discussion mailing list.

I don't think I want to go to the web interface for every new patch
> submission
> someone does and add myself there just in order to get the notifications.

FWIW, the sender can add people to the reviewer list from the CLI when
sending the patch. For example, if you and Patrick are discussing an issue
and you whip out a patch, then it's perfectly kosher for you to upload the
patch with Patrick listed as a reviewer so he automatically gets further
updates and comments.

The gerrit FAQ linked from the coreboot page uses this as an example:
Specific reviewers can be requested and/or additional `carbon copies'' of
the notification message may be sent by including these as arguments to `git
receive-pack:
git push --receive-pack='git receive-pack --reviewer=[e-mail] --cc=[e-mail]'
tr:kernel/common HEAD:refs/for/experimental

gerrit: patch iterations in email [was: differences between patchset iterations]

[Patrick Georgi]

Am Donnerstag, den 09.06.2011, 18:39 +0200 schrieb Uwe Hermann:
> I'd prefer to see all changes for all issues on the mailing list, I don't
> think I want to go to the web interface for every new patch submission
> someone does and add myself there just in order to get the notifications.

Back again.

Patrick

gerrit: patch iterations in email [was: differences between patchset iterations]

[David Hendricks]

On Wed, Jun 15, 2011 at 5:38 AM, Patrick Georgi wrote:
> Am Donnerstag, den 09.06.2011, 18:39 +0200 schrieb Uwe Hermann:
> > I'd prefer to see all changes for all issues on the mailing list, I don't
> > think I want to go to the web interface for every new patch submission
> > someone does and add myself there just in order to get the notifications.
>
> Back again.

Is there an option to keep all these related updates and merges in a single
thread, ie do not display the patch's hash in the subject: line? Shortly
after patch update notifications to the list were re-enabled, three updates
to "i945 GMA: restore tft brightness from cmos" spawned three different
threads within the span of 10 minutes. It has the same effect on my gmail
inbox as it does on the mailing list archive.