#34: flashrom: Fix PIIX4/PIIX4E/PIIX4M code comments ----------------------------+----------------------------------------------- Reporter: uwe | Owner: uwe Type: defect | Status: new Priority: minor | Milestone: Enhance the flashrom utility Component: flashrom | Version: v2 Keywords: | Due_close: MM/DD/YYYY Include_gantt: 0 | Dependencies: Due_assign: MM/DD/YYYY | Patchstatus: there is no patch ----------------------------+----------------------------------------------- Fix some code comments of the Intel PIIX4/PIIX4E/PIIX4M code. Add detailed instructions on how and where to get the datasheet, its name, and order number.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
#34: flashrom: Fix PIIX4/PIIX4E/PIIX4M code comments -----------------------------------+---------------------------------------- Reporter: uwe | Owner: uwe Type: defect | Status: assigned Priority: minor | Milestone: Enhance the flashrom utility Component: flashrom | Version: v2 Resolution: | Keywords: Due_close: MM/DD/YYYY | Include_gantt: 0 Dependencies: | Due_assign: MM/DD/YYYY Patchstatus: patch needs review | -----------------------------------+---------------------------------------- Changes (by uwe):
* status: new => assigned * patchstatus: there is no patch => patch needs review
#34: flashrom: Fix PIIX4/PIIX4E/PIIX4M code comments -----------------------------------+---------------------------------------- Reporter: uwe | Owner: uwe Type: defect | Status: assigned Priority: minor | Milestone: Enhance the flashrom utility Component: flashrom | Version: v2 Resolution: | Keywords: Due_close: MM/DD/YYYY | Include_gantt: 0 Dependencies: | Due_assign: MM/DD/YYYY Patchstatus: patch needs review | -----------------------------------+---------------------------------------- Comment (by stepan):
There's a - missing. Otherwise this patch is fine. (means Acked-By)
the lower 64-Kbyte BIOS block (E0000EFFFF) at the top should read the lower 64-Kbyte BIOS block (E0000-EFFFF) at the top
#34: flashrom: Fix PIIX4/PIIX4E/PIIX4M code comments -----------------------------------------+---------------------------------- Reporter: uwe | Owner: uwe Type: defect | Status: closed Priority: minor | Milestone: Enhance the flashrom utility Component: flashrom | Version: v2 Resolution: fixed | Keywords: Due_close: MM/DD/YYYY | Include_gantt: 0 Dependencies: | Due_assign: MM/DD/YYYY Patchstatus: patch has been committed | -----------------------------------------+---------------------------------- Changes (by uwe):
* patchstatus: patch needs review => patch has been committed