Hi,
I got my TODO covered: the current cbfstool2 works (as cbfstool, that "2" suffix is purely internal) as a drop-in replacement in the coreboot tree, incl. makefiles to build it both for newconfig and kconfig style builds.
The code should match the codingstyle and license headers are added, so I think this is ready to go in.
You can find the tarball at http://www.coresystems.de/~patrick/cbfstool2-0.9.9.tar.bz2
My change would also include a trivial change to newconfig, to only create a $(obj)/cbfs directory, instead of $(obj)/cbfs/tools/lzma, as this isn't necessary anymore.
The "svn diff" is quite messy, as I reused files that are sufficiently similar using svn mv, and those changes aren't well expressed in diff output.
That code is Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Regards, Patrick
Patrick Georgi wrote:
Hi,
I got my TODO covered: the current cbfstool2 works (as cbfstool, that "2" suffix is purely internal) as a drop-in replacement in the coreboot tree, incl. makefiles to build it both for newconfig and kconfig style builds.
The code should match the codingstyle and license headers are added, so I think this is ready to go in.
You can find the tarball at http://www.coresystems.de/~patrick/cbfstool2-0.9.9.tar.bz2
My change would also include a trivial change to newconfig, to only create a $(obj)/cbfs directory, instead of $(obj)/cbfs/tools/lzma, as this isn't necessary anymore.
The "svn diff" is quite messy, as I reused files that are sufficiently similar using svn mv, and those changes aren't well expressed in diff output.
That code is Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Always glad to see additional reviews, but this update was really necessary for future use cases of coreboot / CBFS.
Therefore Acked-by: Stefan Reinauer stepan@coresystems.de
-
Patrick Georgi -
Stefan Reinauer