[coreboot - Bug #475] (New) mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended
Issue #475 has been reported by Bill XIE.
---------------------------------------- Bug #475: mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended https://ticket.coreboot.org/issues/475
* Author: Bill XIE * Status: New * Priority: Normal * Assignee: Arthur Heymans * Category: board support * Target version: master * Start date: 2023-03-30 * Affected versions: 4.15, 4.16, 4.17, 4.18, 4.19, master * Affected hardware: x200 ---------------------------------------- Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().
In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.
This issue may be distantly related to #474.
Issue #475 has been updated by Bill XIE.
Assignee changed from Arthur Heymans to Bill XIE % Done changed from 0 to 90 Related links updated
---------------------------------------- Bug #475: mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended https://ticket.coreboot.org/issues/475#change-1463
* Author: Bill XIE * Status: New * Priority: Normal * Assignee: Bill XIE * Category: board support * Target version: master * Start date: 2023-03-30 * Affected versions: 4.15, 4.16, 4.17, 4.18, 4.19, master * Related links: This is going to be fixed with https://review.coreboot.org/c/coreboot/+/74181 . * Affected hardware: x200 ---------------------------------------- Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().
In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.
This issue may be distantly related to #474.
Issue #475 has been updated by Martin Roth.
Can this be closed now?
---------------------------------------- Bug #475: mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended https://ticket.coreboot.org/issues/475#change-1530
* Author: Bill XIE * Status: New * Priority: Normal * Assignee: Bill XIE * Category: board support * Target version: master * Start date: 2023-03-30 * Affected versions: 4.15, 4.16, 4.17, 4.18, 4.19, master * Related links: This is going to be fixed with https://review.coreboot.org/c/coreboot/+/74181 . * Affected hardware: x200 ---------------------------------------- Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().
In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.
This issue may be distantly related to #474.
Issue #475 has been updated by Bill XIE.
Martin Roth wrote in #note-3:
Can this be closed now?
Sure.
---------------------------------------- Bug #475: mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended https://ticket.coreboot.org/issues/475#change-1614
* Author: Bill XIE * Status: New * Priority: Normal * Assignee: Bill XIE * Category: board support * Target version: master * Start date: 2023-03-30 * Affected versions: 4.15, 4.16, 4.17, 4.18, 4.19, master * Related links: This is going to be fixed with https://review.coreboot.org/c/coreboot/+/74181 . * Affected hardware: x200 ---------------------------------------- Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().
In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.
This issue may be distantly related to #474.
Issue #475 has been updated by Martin Roth.
Status changed from New to Resolved
---------------------------------------- Bug #475: mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended https://ticket.coreboot.org/issues/475#change-1698
* Author: Bill XIE * Status: Resolved * Priority: Normal * Assignee: Bill XIE * Category: board support * Target version: master * Start date: 2023-03-30 * Affected versions: 4.15, 4.16, 4.17, 4.18, 4.19, master * Related links: This is going to be fixed with https://review.coreboot.org/c/coreboot/+/74181 . * Affected hardware: x200 ---------------------------------------- Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().
In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.
This issue may be distantly related to #474.
-
Bill XIE -
Martin Roth